Remove publishing opt-out for nuget assets #47708
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet assets now produce a properly build-varying version in official builds.
ghost
added
There was a problem hiding this comment.
Pull Request Overview
This PR removes the legacy nuget assets publishing opt-out behavior as part of ensuring NuGet assets produce proper build-varying versions in official builds.
- Removed exclusion logic for nuget-client assets.
- Cleaned up outdated comments referencing excluded NuGet assets.
Comments suppressed due to low confidence (1)
src/SourceBuild/content/eng/tools/tasks/Microsoft.DotNet.UnifiedBuild.Tasks/ManifestAssets/JoinVerticalsAssetSelector.cs:47
- Ensure the removal of the nuget-client exclusion logic is properly covered by updated tests so that unintended nuget asset inclusion issues are caught.
StringComparer.OrdinalIgnoreCase.Equals(assetVerticalMatch.AssetId, "Microsoft.NET.Sdk.Aspire.Manifest-8.0.100") ||
jkoritzinsky
approved these changes
Mar 18, 2025
ViktorHofer
approved these changes
Mar 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NuGet assets now produce a properly build-varying version in official builds.