Skip to content

Remove unnecessary 32bit arm architecture checks in the Windows build #47656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 17, 2025
Merged

Remove unnecessary 32bit arm architecture checks in the Windows build #47656

merged 1 commit into from
Mar 17, 2025

Conversation

akoeplinger
Copy link
Member

We only build for arm64 on Windows since .NET 5.

@akoeplinger
Remove unnecessary 32bit arm architecture checks in the Windows build
a15df19 
We only build for arm64 on Windows since .NET 5.
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Mar 17, 2025
Copilot
Copilot AI reviewed Mar 17, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

@akoeplinger akoeplinger enabled auto-merge (squash) March 17, 2025 11:41
@akoeplinger
Copy link
Member Author

Failure is unrelated

@akoeplinger akoeplinger disabled auto-merge March 17, 2025 15:47
@akoeplinger akoeplinger merged commit 706bc55 into dotnet:main Mar 17, 2025
36 of 41 checks passed
@akoeplinger akoeplinger deleted the remove-arm branch March 17, 2025 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

Copilot code review Copilot Copilot left review comments

@ViktorHofer ViktorHofer ViktorHofer approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoeplinger @ViktorHofer