Fix global properties not propagating in new dotnet test for MTP #47464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Youssef1313
force-pushed
the
dev/ygerges/fix-dotnet-test-global-prop
branch
from
c6c6fb3 to
11b36ea
Compare
Youssef1313
force-pushed
the
dev/ygerges/fix-dotnet-test-global-prop
branch
from
11b36ea to
57c433c
Compare
Evangelink
approved these changes
Mar 11, 2025
| <Project Sdk="Microsoft.NET.Sdk"> | ||
| <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory), testAsset.props))\testAsset.props" /> | ||
|
|
||
| <PropertyGroup> |
There was a problem hiding this comment.
Nit: Is it normal to have tabs?
There was a problem hiding this comment.
I copied from existing test assets, e.g:
There was a problem hiding this comment.
We should consider ensuring formatting is aligned with .editorconfig which seems to be using two spaces for csproj. cc @mariam-abdulla
mariam-abdulla
approved these changes
Mar 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #45927
CommonOptions.PropertiesOption(i.e,-p/--property/etc) as a command line option for the new dotnet test experience.BuildOptionsGetGlobalPropertiesGetPropertyTokensas it's now not "unmatched token".