Remove ForceDryRunSigning=true on Mac & Linux signed builds
#47461
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
ellahathaway
force-pushed
the
remove-forced-dryrun-signing
branch
from
ec169e4 to
a798d6c
Compare
|
Needs #47792 before this can be merged |
There was a problem hiding this comment.
Pull Request Overview
This PR updates the build configuration by disabling the default signing flag on Mac & Linux builds and refactoring command line arguments into well‐defined properties. Key changes include:
- Changing the default value for the "sign" parameter from true to false.
- Refactoring command line construction by introducing new properties (e.g., commandPrefix, cleanArgument, baseProperties, targetProperties, signProperties, buildPassProperties, and ibcProperties).
- Adjusting build and test command invocations to use these new properties for clarity and maintainability.
ellahathaway
commented
Mar 25, 2025
| ## Basic arguments | ||
| - name: baseArguments | ||
| value: -ci -cleanWhileBuilding -prepareMachine -c ${{ parameters.configuration }} $(officialBuildParameter) /p:VerticalName=$(Agent.JobName) /p:ArtifactsStagingDir=$(artifactsStagingDir) | ||
| ## Build command line |
There was a problem hiding this comment.
I made the build command args/props available to all OS platforms so that the mac & linux legs could use the signing args + props.
ellahathaway
commented
Mar 25, 2025
| - ${{ else }}: | ||
| - name: ibcArguments | ||
| value: '' | ||
| # Timeout |
There was a problem hiding this comment.
I moved the timeout logic here so that the timeout could be conditionally set based on the value of _SignType
mmitche
approved these changes
Mar 25, 2025
|
@mmitche - can I get help merging this? This failures are unrelated. Thanks in advance. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes dotnet/source-build#4678