Skip to content

[release/9.0.3xx] make container app/entrypoint argument defaults only happen on the RID-specific builds, not the outer RID-less build #47458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

baronfel
Copy link
Member

Manual backport of #47424 to release/9.0.3xx due to code changes across the branches.

…D-specific builds, not the outer RID-less build
@Copilot Copilot AI review requested due to automatic review settings March 11, 2025 16:32
@baronfel baronfel requested a review from a team as a code owner March 11, 2025 16:32
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Mar 11, 2025
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR backports changes from #47424 to ensure that container app/entrypoint argument defaults are applied only on the RID-specific builds and not on the outer RID-less build.

  • Adds a new public readonly string for container execution arguments in KnownStrings.cs.
  • Updates integration tests in TargetsTests.cs to reference the new property instead of the old one.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
src/Containers/Microsoft.NET.Build.Containers/KnownStrings.cs Added a new property for container execution arguments.
test/Microsoft.NET.Build.Containers.IntegrationTests/TargetsTests.cs Updated test build targets to use the new container execution args property.
Comments suppressed due to low confidence (1)

src/Containers/Microsoft.NET.Build.Containers/KnownStrings.cs:30

  • [nitpick] Consider renaming _ComputeContainerExecutionArgs to ComputeContainerExecutionArgs to better align with .NET public member naming conventions.
public static readonly string _ComputeContainerExecutionArgs = nameof(_ComputeContainerExecutionArgs);

@baronfel
Copy link
Member Author

/azp run sdk-unified-build

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@baronfel baronfel enabled auto-merge (squash) March 11, 2025 21:15
@baronfel baronfel merged commit ee6836b into dotnet:main Mar 11, 2025
41 checks passed
@baronfel baronfel deleted the backport-47424-to-9.0.3xx branch March 18, 2025 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants