[wasm] Opt-in to use dotnet.boot.js #47451
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
There was a problem hiding this comment.
Pull Request Overview
This PR updates the boot configuration to explicitly use "dotnet.boot.js" and prepares tests for the new default configuration.
- Adds a new BootJsonDataLoader class to parse boot configuration JSON content from boot.js.
- Replaces hard-coded boot configuration file names with an interpolated variable in tests.
Reviewed Changes
Copilot reviewed 35 out of 35 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test/Microsoft.NET.Sdk.BlazorWebAssembly.Tests/BootJsonData.cs | Added a new BootJsonDataLoader and updated namespace style |
| test/Microsoft.NET.Sdk.BlazorWebAssembly.AoT.Tests/WasmAoTPublishIntegrationTest.cs | Replaced hard-coded boot config filename with an interpolated variable |
pavelsavara
approved these changes
Mar 11, 2025
javiercn
approved these changes
Mar 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explicitly set
WasmBootConfigFileName=dotnet.boot.jsto prepare all tests that this is the new default.In the follow-up we'll remove the explicit property set.
In another follow-up we will update some tests to be more agnostic to exact boot config schema.
Contributes to dotnet/aspnetcore#59456