Skip to content

Run AddImplicitDefineConstants after PrepareForBuild. #45877

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Mar 21, 2025

Conversation

teo-tsirpanis
Copy link
Contributor

@Sergio0694
Copy link
Contributor

@rainersigwald thoughts on this? Was wondering if we could get it into 9.0.3xx perhaps? Thank you! 😄

@marcpopMSFT
Copy link
Member

/backport to release/9.0.3xx

Copy link
Contributor

Started backporting to release/9.0.3xx: https://github.com/dotnet/sdk/actions/runs/13996946375

@marcpopMSFT marcpopMSFT merged commit 782cc9a into dotnet:main Mar 21, 2025
39 checks passed
@teo-tsirpanis teo-tsirpanis deleted the after-prepare-for-build branch March 21, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-NetSDK untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

'AddImplicitDefineConstants' runs too late, and defines are missing when 'XamlPreCompile' runs, causing build failures
4 participants