Skip to content

Extend build server shutdown tracing #45393

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

jjonescz
Copy link
Member

@jjonescz jjonescz commented Dec 10, 2024

The output might look something like this:

❯ & "D:\sdk-3\.dotnet\dotnet.exe" exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\dotnet.dll build-server shutdown --vbcscompiler
Telemetry is: Disabled
Shutting down VB/C# compiler server...
Running D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown
> D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown
Process ID: 43340
< D:\sdk-3\.dotnet\dotnet.exe exec D:\sdk-3\artifacts\bin\dotnet\Debug\net10.0\Roslyn\bincore\VBCSCompiler.dll -shutdown exited with -2147450751 in 21 ms.
Shutting down 'microsoft.net.sdk.compilers.toolset' compilers.
Enumerating 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset'.
Found 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe'.
Running C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown
> C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown
Process ID: 22744
< C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.100-preview.7.24365.12\VBCSCompiler.exe -shutdown exited with 0 in 112 ms.
Found 'C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe'.
Running C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown
> C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown
Process ID: 23660
< C:\.tools\.nuget\packages\microsoft.net.sdk.compilers.toolset\9.0.101\VBCSCompiler.exe -shutdown exited with 0 in 113 ms.

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-CLI untriaged Request triage from a team member labels Dec 10, 2024
@jjonescz jjonescz marked this pull request as ready for review December 10, 2024 14:16
Copy link
Member

@ellahathaway ellahathaway left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@ellahathaway
Copy link
Member

Related to dotnet/source-build#4796

@baronfel
Copy link
Member

The arm64 failures on macOS have been pretty persistent - @marcpopMSFT mind merging this on red to get better diagnosis?

@marcpopMSFT marcpopMSFT merged commit e423f31 into dotnet:main Dec 10, 2024
35 of 38 checks passed
@ViktorHofer
Copy link
Member

This broke the build :( Raced with b09e142

src/Cli/Microsoft.DotNet.Cli.Utils/Command.cs(44,28): error CS8600: (NETCORE_ENGINEERING_TELEMETRY=Build) Converting null literal or possible null value to non-nullable type.

@v-wuzhai
Copy link
Member

@jaredpar I tried to resolve the build failure, but it seems there are still other issues. Could you take a look at #45411?

@jjonescz jjonescz deleted the shutdown-tracing branch December 11, 2024 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CLI untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants