Skip to content

Merge toolset-tasks and core-sdk-tasks and put in common location #45242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Dec 2, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Dec 2, 2024

Merge the local repo tasks that come from the installer and the sdk repositories together into a single one "sdk-tasks" and move it under src/Tasks/sdk-tasks/.

  • Delete duplicate task files
  • Use TaskHostFactory to run the local tasks out-of-proc which avoids the separate project build and special target and makes it easier to "consume" the task project.

This contributes to dotnet/source-build#4777

@ViktorHofer ViktorHofer requested review from a team as code owners December 2, 2024 12:03
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Dec 2, 2024
Merge the local repo tasks that come from the installer and the sdk
repositories together into a single one "sdk-tasks" and move it under
src/Tasks/sdk-tasks/.

Delete duplicate task files.
@ViktorHofer ViktorHofer enabled auto-merge (squash) December 2, 2024 15:28
@ViktorHofer ViktorHofer disabled auto-merge December 2, 2024 16:46
@ViktorHofer ViktorHofer enabled auto-merge (squash) December 2, 2024 16:54
@ViktorHofer ViktorHofer merged commit 2f721c2 into main Dec 2, 2024
38 checks passed
@ViktorHofer ViktorHofer deleted the MergeSdkLocalTasksTogether branch December 2, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants