Skip to content

randomize GetTestDestinationDirectoryPath #45130

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 26, 2024
Merged

Conversation

kasperk81
Copy link
Contributor

lots of failures in theory tests such as

Microsoft.DotNet.Cli.Sln.List.Tests.GivenDotnetSlnList.WhenInvalidSolutionIsPassedItPrintsErrorAndUsage(solutionCommand: "sln") [FAIL]
      System.Exception : Test dir /private/tmp/helix/working/AD1509AD/w/BB910A35/e/testExecutionDirectory/WhenInvalidSo---F1406920_2 already exists

@kasperk81
Copy link
Contributor Author

@edvilme this will fix the directory name conflict seen in #44570 when there are more than two theories relying on distinct naming _1 and _2 are not enough

@edvilme
Copy link
Member

edvilme commented Nov 26, 2024

@edvilme this will fix the directory name conflict seen in #44570 when there are more than two theories relying on distinct naming _1 and _2 are not enough

Thanks for your contribution! This will be very helpful both for that PR and for further testing scenarios :)

@edvilme edvilme merged commit 4317236 into dotnet:main Nov 26, 2024
38 checks passed
@kasperk81 kasperk81 deleted the patch-4 branch November 26, 2024 20:24
edvilme added a commit to edvilme/sdk that referenced this pull request Dec 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants