Remove global:: from generated global usings
#44916
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
1 similar comment
|
I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label. |
333fred
reviewed
Nov 18, 2024
| @@ -103,6 +103,7 @@ public void It_can_generate_custom_usings() | |||
| <Using Include=""CustomNamespace"" /> | |||
| <Using Include=""TestStaticNamespace"" Static=""True"" /> | |||
| <Using Include=""System.Biology"" Alias=""AppliedChemistry"" /> | |||
| <Using Include=""(System.String X, int Y)"" Alias=""MyTuple"" /> | |||
There was a problem hiding this comment.
Let's add a direct keyword example, like making an alias for int or dynamic.
333fred
approved these changes
Nov 19, 2024
|
@jaredpar @marcpopMSFT I'm not sure what reviews do I need for this one |
jaredpar
approved these changes
Nov 22, 2024
It just needs sign off from us so when you're ready merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42479.