Skip to content

[main] Update dependencies from dotnet/arcade #44757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 18 commits into from
Nov 15, 2024

Conversation

dotnet-maestro[bot]
Copy link
Contributor

@dotnet-maestro dotnet-maestro bot commented Nov 8, 2024

This pull request updates the following dependencies

From https://github.com/dotnet/arcade

  • Subscription: 3d9043af-0e17-4eb5-f3e3-08d8e97c775d
  • Build: 20241114.1
  • Date Produced: November 14, 2024 10:19:48 AM UTC
  • Commit: c1852b9ac37df9a86630c2f078dbee43f7b186e7
  • Branch: refs/heads/main

…107.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24557.1
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Nov 8, 2024
@mthalman mthalman requested review from a team as code owners November 8, 2024 15:12
@mthalman
Copy link
Member

mthalman commented Nov 8, 2024

@premun - I cannot figure out why it's complaining about this arcade patch. Can you take a look? The issue of the tip being busted is resolved. But now when trying to update the Arcade version, the patch isn't working no matter what I try.

…108.2

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24558.2
…110.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24560.1
@premun
Copy link
Member

premun commented Nov 12, 2024

@mthalman we found a problem yesterday with @akoeplinger. I have a fix ready but need to build/flow it.

ETA is 2 hours

dotnet-maestro bot and others added 3 commits November 12, 2024 13:22
…111.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24561.1
…6f-4e98-bdf1-c0061e748f19

# Conflicts:
#	.config/dotnet-tools.json
#	eng/Version.Details.xml
#	eng/Versions.props
@premun
Copy link
Member

premun commented Nov 12, 2024

I was able to synchronize this PR locally with the updated darc but now it's failing again. I will check if maybe now it's a real conflict

@premun
Copy link
Member

premun commented Nov 12, 2024

@mthalman I believe the 0002 patch should be removed as it was already applied here: dotnet/arcade@32b8acf

@premun premun enabled auto-merge (squash) November 12, 2024 20:57
…112.15

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24562.15
@premun premun disabled auto-merge November 13, 2024 14:38
@premun
Copy link
Member

premun commented Nov 13, 2024

@mthalman I removed one patch but the other one is outdated and needs rebasing and I don't really understand what is it doing so I will leave it up to you. However the synchronization issue is fixed

@akoeplinger
Copy link
Member

@jkoritzinsky does this need dotnet/runtime#109710 or are these separate issues?

chmod: cannot access '/vmr/src/runtime/artifacts/obj/Microsoft.NETCore.App.Ref/Release/net10.0/linux-x64/installer/debLayout/control/postinst': No such file or directory
chmod: cannot access '/vmr/src/runtime/artifacts/obj/Microsoft.NETCore.App.Ref/Release/net10.0/linux-x64/installer/debLayout/control/postrm': No such file or directory
/vmr/src/runtime/artifacts/sb/package-cache/microsoft.dotnet.build.tasks.installers/10.0.0-beta.24562.15/build/installer.build.targets(268,5): error MSB3073: The command "chmod ugo+x '/vmr/src/runtime/artifacts/obj/Microsoft.NETCore.App.Ref/Release/net10.0/linux-x64/installer/debLayout/control/postinst' '/vmr/src/runtime/artifacts/obj/Microsoft.NETCore.App.Ref/Release/net10.0/linux-x64/installer/debLayout/control/postrm'" exited with code 1. [/vmr/src/runtime/src/installer/pkg/sfx/Microsoft.NETCore.App/Microsoft.NETCore.App.Ref.sfxproj]

and

 D:\a\_work\1\vmr\src\runtime\artifacts\sb\package-cache\microsoft.dotnet.build.tasks.installers\10.0.0-beta.24562.15\build\installer.targetos.targets(3,5): error MSB4184: The expression """.Substring(0, -1)" cannot be evaluated. length ('-1') must be a non-negative value. (Parameter 'length') Actual value was -1. [D:\a\_work\1\vmr\src\runtime\artifacts\sb\package-cache\microsoft.dotnet.build.tasks.installers\10.0.0-beta.24562.15\build\acquisition\acquire-wix\acquire-wix.proj]

@jkoritzinsky
Copy link
Member

No this is a bug I'm working on fixing in the Arcade changes. Should have a fix by the afternoon.

@jkoritzinsky
Copy link
Member

As soon at this build passes, an Arcade version with the fix should be pushed here by darc: https://dev.azure.com/dnceng/internal/_build/results?buildId=2581568&view=results

If not, I'll manually trigger the subscription if I'm still online.

dotnet-maestro bot and others added 6 commits November 14, 2024 01:55
…113.7

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24563.7
…114.1

Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions
 From Version 10.0.0-beta.24555.1 -> To Version 10.0.0-beta.24564.1
@ViktorHofer ViktorHofer enabled auto-merge (squash) November 15, 2024 14:03
@ViktorHofer ViktorHofer merged commit 2bfb526 into main Nov 15, 2024
39 of 40 checks passed
@ViktorHofer ViktorHofer deleted the darc-main-e3f1da8c-606f-4e98-bdf1-c0061e748f19 branch November 15, 2024 16:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-CodeFlow untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants