-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Allow ProjectReferences to not have the _GetRequiredWorkloads Target #44593
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow ProjectReferences to not have the _GetRequiredWorkloads Target #44593
Conversation
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.ImportWorkloads.targets
Outdated
Show resolved
Hide resolved
src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.ImportWorkloads.targets
Outdated
Show resolved
Hide resolved
6c77b97
to
57806d9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If it's not too complicated it would be nice to have a test for this.
This prevents a ProjectReference to an esproj project (and other project types) from failing when `dotnet workload restore` is called on a .NET project.
…ImportWorkloads.targets
7c5c96a
to
c0909bb
Compare
@dsplaisted I got a test in :) |
/backport to release/9.0.2xx |
Started backporting to release/9.0.2xx: https://github.com/dotnet/sdk/actions/runs/11716574907 |
@marcpopMSFT anything against a backport to 8? Folks are using esproj with 8, and that's the primary way I'd expect to trigger this. |
@baronfel do we have customer reports of this in 8? The bug for this was from last week so it's hard to say how critical this is in 8 so I'd probably hold off for now unless we had more feedback. |
@joj / @danroth27 do you have any indication on what SDK's esproj users are using, especially if they are also using .NET SDK workloads? |
All .esproj based projects use the JavaScript SDK; Microsoft.VisualStudio.JavaScript.Sdk. Since these are JavaScript based projects, you don't typically use any .NET based SDKs with them. However, you might have an ASP.NET Core project or a Razor Class Library project that references the .esproj. ASP.NET Core projects use the Web SDK (Microsoft.NET.Sdk.Web) and Razor Class Libraries use the Razor SDK (Microsoft.NET.Sdk.Razor). |
Sorry - I wasn't super clear. I meant versions of the .NET SDK and CLI tooling, like "most esproj users use .NET 8.0.2xx", or "MAUI + esproj users mostly use latest and so are on 8.0.4xx", that kind of thing. Trying to judge impact for a backport decision. |
This prevents a ProjectReference to an esproj project (and other project types) from failing when
dotnet workload restore
is called on a .NET project.Fixes #44587
I would want to backport to 8.0.x after merging because 8.x is LTS.