Skip to content

Remove prep-source-build.sh invocation from vmr devcontainer config #44548

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 31, 2024
Merged

Remove prep-source-build.sh invocation from vmr devcontainer config #44548

merged 2 commits into from
Oct 31, 2024

Conversation

ViktorHofer
Copy link
Member

@ViktorHofer ViktorHofer commented Oct 31, 2024 •
edited
Loading

The docs explicitly mention that the prep-source-build.sh script needs to be invoked for source-build scenarios: https://github.com/dotnet/sdk/blob/main/.devcontainer/vmr/README.md#build-the-sdk

Remove the invocation in init.sh as otherwise non-source-only builds fail to build inside the VMR (roslyn is missing a winmd file).

Also update CODEOWNERS file

@ViktorHofer
Remove prep-source-build.sh invocation from vmr devcontainer config
e829b57 
The docs explicitly mention that the prep-source-build.sh script needs to be invoked for source-build scenarios: https://github.com/dotnet/sdk/blob/main/.devcontainer/vmr/README.md#build-the-sdk

Remove the invocation in init.sh as otherwise non-source-only builds fail to build inside the VMR (roslyn is missing a winmd file).
@ViktorHofer ViktorHofer requested a review from a team as a code owner October 31, 2024 11:08
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 31, 2024
@akoeplinger
Copy link
Member

akoeplinger commented Oct 31, 2024 •
edited
Loading

roslyn is missing a winmd file

Interesting that it tries to do something with it on linux? that should be windows-only
ah now I remember, it is embedding it in https://github.com/dotnet/roslyn/blob/08a167c19e5e04742b0922bdb1ea8046e9364f4b/src/ExpressionEvaluator/Core/Source/ExpressionCompiler/Microsoft.CodeAnalysis.ExpressionCompiler.csproj#L30-L32 but that whole ExpressionEvaluator tree is disabled in source-build mode (dotnet/roslyn#66718).

@ViktorHofer ViktorHofer enabled auto-merge (squash) October 31, 2024 11:20
@ViktorHofer ViktorHofer merged commit ae79890 into main Oct 31, 2024
37 checks passed
@ViktorHofer ViktorHofer deleted the ViktorHofer-patch-3 branch October 31, 2024 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akoeplinger akoeplinger akoeplinger approved these changes

@premun premun premun approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ViktorHofer @akoeplinger @premun