[VMR] Install dependencies on macOS #44294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks like ICU got removed from the internal macOS image, breaking the VMR build. Install the deps from the runtime requirements to fix that.
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
am11
approved these changes
Oct 18, 2024
|
Yeah I agree, this was just a quick fix to unbreak the build. |
ViktorHofer
approved these changes
Oct 18, 2024
ViktorHofer
reviewed
Oct 18, 2024
| @@ -298,6 +298,10 @@ jobs: | |||
| timeoutInMinutes: ${{ variables.runTestsTimeout }} | |||
|
|
|||
| - ${{ else }}: | |||
| - ${{ if eq(variables['Agent.Os'], 'Darwin') }}: | |||
There was a problem hiding this comment.
If this temporary, please add a TODO marker or if you don't want to re-spin a new build, file an issue.
There was a problem hiding this comment.
I think we will need a dependency installation step so from that point of view it's not temporary, but it might look a bit different that this. keeping it as is now.
There was a problem hiding this comment.
OK. FWIW we already have such a step for Windows:
sdk/eng/pipelines/templates/jobs/vmr-build.yml
Lines 275 to 281 in cf30ac2
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like ICU got removed from the internal macOS image, breaking the VMR build. Install the deps from the runtime requirements to fix that.