Skip to content

Don't fire PR pipelines for the VMR unified build as well #43944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

baronfel
Copy link
Member

@baronfel baronfel commented Oct 7, 2024

Like #43940, but also works for the VMR pipeline.

@baronfel baronfel requested review from a team as code owners October 7, 2024 20:29
@ghost ghost added Area-Infrastructure untriaged Request triage from a team member labels Oct 7, 2024
@MichaelSimons
Copy link
Member

Why is this needed? Wasn't this change included in #43940?

@baronfel
Copy link
Member Author

baronfel commented Oct 7, 2024

Chatting with @ellahathaway on Teams, my confusion was because the UB pipelines were still running on a PR I thought wouldn't trigger them (#43938), and she's checking why they still fired.

@baronfel
Copy link
Member Author

baronfel commented Oct 7, 2024

This PR was made because I am a dummy that doesn't know how to properly sync branches before making changes.

@baronfel baronfel closed this Oct 7, 2024
@baronfel baronfel deleted the no-fire-for-docs-on-vmr-too branch October 7, 2024 20:36
@ellahathaway
Copy link
Member

ellahathaway commented Oct 7, 2024

Chatting with @ellahathaway on Teams, my confusion was because the UB pipelines were still running on a PR I thought wouldn't trigger them (#43938), and she's checking why they still fired.

Followed up in teams - it was still triggering because we were manually overriding the triggers for the UB pipeline via the Azdo UI. I've manually added the exclusion paths via the UI, so the triggers should work as expected now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants