Skip to content

use SpecialFolder.UserProfile in few places #43826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 15, 2024
Merged

use SpecialFolder.UserProfile in few places #43826

merged 2 commits into from
Oct 15, 2024

Conversation

kasperk81
Copy link
Contributor

same as CliFolderPathCalculatorCore code:

sdk/src/Common/CliFolderPathCalculatorCore.cs

Lines 34 to 38 in c3a8f72

{
home = Environment.GetEnvironmentVariable(PlatformHomeVariableName);
if (string.IsNullOrEmpty(home))
{
home = Environment.GetFolderPath(Environment.SpecialFolder.UserProfile);

@kasperk81 kasperk81 requested review from a team as code owners October 1, 2024 23:43
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Oct 1, 2024
@kasperk81
Copy link
Contributor Author

@marcpopMSFT please take a look.

@marcpopMSFT
Copy link
Member

Makes sense. I guess we'll take the duplication for now.

@dotnet/razor-compiler can you double check the change to the RazorSDK?

@build-analysis build-analysis bot mentioned this pull request Oct 14, 2024
Closed
@marcpopMSFT marcpopMSFT merged commit 456aa42 into dotnet:main Oct 15, 2024
36 checks passed
@marcpopMSFT
Copy link
Member

Thanks for the contribution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@333fred 333fred 333fred approved these changes

@jjonescz jjonescz jjonescz approved these changes

@marcpopMSFT marcpopMSFT marcpopMSFT approved these changes

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kasperk81 @marcpopMSFT @333fred @jjonescz