-
Notifications
You must be signed in to change notification settings - Fork 1.1k
[StaticWebAssets] Process endpoint definitions in parallel #43736
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
javiercn
merged 5 commits into
main
from
javiercn/parallel-define-static-webasset-endpoints
Oct 11, 2024
Merged
[StaticWebAssets] Process endpoint definitions in parallel #43736
javiercn
merged 5 commits into
main
from
javiercn/parallel-define-static-webasset-endpoints
Oct 11, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Sep 27, 2024
bb93e2a
to
9389124
Compare
9389124
to
32f444d
Compare
MackinnonBuck
approved these changes
Oct 8, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just a few small suggestions.
32f444d
to
c1f409c
Compare
c1f409c
to
e007c41
Compare
javiercn
commented
Oct 11, 2024
javiercn
added a commit
that referenced
this pull request
Mar 26, 2025
javiercn
added a commit
that referenced
this pull request
Apr 21, 2025
javiercn
added a commit
that referenced
this pull request
Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DefineStaticWebAssetEndpoints
calls for build assets (they aren't needed).Around ~1s saving
Before
After