[Blazor] Fix hot reload for components with collocated JS files #43199
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dotnet-issue-labeler
bot
added
Area-Infrastructure
untriaged
MackinnonBuck
force-pushed
the
mbuck/fix-collocated-js-hot-reload
branch
from
8047b50 to
7b09a07
Compare
MackinnonBuck
requested review from
a team,
tmat and
arunchndr
as code owners
MackinnonBuck
changed the title
javiercn
reviewed
Sep 6, 2024
src/StaticWebAssetsSdk/Targets/Microsoft.NET.Sdk.StaticWebAssets.JSModules.targets
Outdated
Show resolved
Hide resolved
|
You'll need to update to latest |
…om/dotnet/sdk into mbuck/fix-collocated-js-hot-reload
javiercn
approved these changes
Sep 10, 2024
This was referenced Sep 11, 2024
|
/backport to release/9.0.1xx |
|
Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/12017540612 |
10 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some targets weren't re-running after a hot reload edit was made, and this caused the
ApplyJsModulestask to fail. This PR fixes the issue by updating theResolveJSModuleStaticWebAssetstarget to list out its missingDependsOnTargets.Fixes dotnet/aspnetcore#57599