Skip to content

add signature VerifySigning for dotnet tools #39268

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Aug 28, 2024

Update src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs

87520e5
Select commit
Loading
Failed to load commit list.
Merged

add signature VerifySigning for dotnet tools #39268

Update src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs
87520e5
Select commit
Loading
Failed to load commit list.
Build Analysis / Build Analysis failed Jul 31, 2024 in 0s

.NET Result Analysis

Details

Tip

To unconditionally bypass the build analysis check (turn it green), you can use the escape mechanism feature. The completion time may vary, potentially taking several minutes, depending on the build analysis workload at the moment.

Build Failures

sdk-unified-build / VMR Vertical Build / Ubuntu2404_DevVersions_x64 / Build

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌expand to see the full error
      /vmr/repo-projects/Directory.Build.targets(428,5): error MSB3073: The command "/vmr/src/sdk/eng/common/build.sh --restore --build --pack --publish --ci --configuration Release -bl /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=/vmr/artifacts/obj/sdk/NuGet.config /p:SourceBuiltAssetsDir=/vmr/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/vmr/artifacts/obj/AssetManifests/sdk/ /p:PackageProjectUrl=https://github.com/dotnet/sdk /p:PortableRid=linux-x64 /p:TargetRid=linux-x64 --v minimal /p:NETCoreAppMaximumVersion=99.9 /p:PortableOSName=linux /p:Rid=linux-x64 /p:Architecture=x64 /p:DOTNET_INSTALL_DIR=/vmr/.dotnet/ /p:AspNetCoreInstallerRid=linux-x64 /p:NetRuntimeRid=linux-x64 /p:SkipBuildingInstallers=true /p:PublicBaseURL=file:///vmr/artifacts/assets/Release/ /p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/ /p:UsePortableLinuxSharedFramework=false /p:SourceBuiltShippingPackagesDir=/vmr/artifacts/packages/Release/Shipping/sdk/ /p:SourceBuiltNonShippingPackagesDir=/vmr/artifacts/packages/Release/NonShipping/sdk/ > /vmr/artifacts/log/Release/sdk.log 2>&1" exited with code 1.
    ❌/vmr/src/sdk/src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs(157,17): error CS1061: 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' does not contain a definition for 'GetAwaiter' and no accessible extension method 'GetAwaiter' accepting a first argument of type 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' could be found (are you missing a using directive or an assembly reference?)
    ❌expand to see the full error
      /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcadeBuild.targets(130,5): error MSB3073: The command "/vmr/.dotnet//dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:false /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=true /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj /bl:"/vmr/src/sdk/artifacts/log/Release/Build.binlog" /p:Configuration=Release /p:RepoRoot=/vmr/src/sdk/ /p:Restore=true /p:Build=true /p:DotNetBuildRepo=false /p:ArcadeBuildFromSource=false /p:DotNetBuildSourceOnly=false /p:Rebuild=false /p:Test=false /p:Pack=true /p:IntegrationTest=false /p:PerformanceTest=false /p:Sign=false /p:Publish=true /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=/vmr/artifacts/obj/sdk/NuGet.config /p:SourceBuiltAssetsDir=/vmr/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/vmr/artifacts/obj/AssetManifests/sdk/ /p:PackageProjectUrl=https://github.com/dotnet/sdk /p:PortableRid=linux-x64 /p:TargetRid=linux-x64 /p:NETCoreAppMaximumVersion=99.9 /p:PortableOSName=linux /p:Rid=linux-x64 /p:Architecture=x64 /p:DOTNET_INSTALL_DIR=/vmr/.dotnet/ /p:AspNetCoreInstallerRid=linux-x64 /p:NetRuntimeRid=linux-x64 /p:SkipBuildingInstallers=true /p:PublicBaseURL=file:///vmr/artifacts/assets/Release/ /p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/ /p:UsePortableLinuxSharedFramework=false /p:SourceBuiltShippingPackagesDir=/vmr/artifacts/packages/Release/Shipping/sdk/ /p:SourceBuiltNonShippingPackagesDir=/vmr/artifacts/packages/Release/NonShipping/sdk/ -logger:/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/net9.0/Microsoft.DotNet.ArcadeLogging.dll /p:DotNetBuildInnerRepo=true /p:DotNetBuildSourceOnly=false /p:RepoRoot="/vmr/src/sdk/" /p:ArtifactsDir="/vmr/src/sdk/artifacts/" /bl:"/vmr/src/sdk/artifacts/log/Release/source-inner-build.binlog" /p:ContinuousIntegrationBuild=true /p:SourceBuildOutputDir="/vmr/src/sdk/artifacts/sb/" /p:DotNetPackageVersionPropsPath="/vmr/artifacts/obj/PackageVersions/PackageVersions.sdk.props" /p:FullAssemblySigningSupported=false /p:DotNetPublishUsingPipelines=true /p:GitHubRepositoryName=sdk" exited with code 1.

sdk-unified-build / VMR Vertical Build / Ubuntu2404_x64 / Build

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌expand to see the full error
      /vmr/repo-projects/Directory.Build.targets(428,5): error MSB3073: The command "/vmr/src/sdk/eng/common/build.sh --restore --build --pack --publish --ci --configuration Release -bl /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=/vmr/artifacts/obj/sdk/NuGet.config /p:SourceBuiltAssetsDir=/vmr/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/vmr/artifacts/obj/AssetManifests/sdk/ /p:PackageProjectUrl=https://github.com/dotnet/sdk /p:PortableRid=linux-x64 /p:TargetRid=linux-x64 --v minimal /p:NETCoreAppMaximumVersion=99.9 /p:PortableOSName=linux /p:Rid=linux-x64 /p:Architecture=x64 /p:DOTNET_INSTALL_DIR=/vmr/.dotnet/ /p:AspNetCoreInstallerRid=linux-x64 /p:NetRuntimeRid=linux-x64 /p:SkipBuildingInstallers=true /p:PublicBaseURL=file:///vmr/artifacts/assets/Release/ /p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/ /p:UsePortableLinuxSharedFramework=false /p:SourceBuiltShippingPackagesDir=/vmr/artifacts/packages/Release/Shipping/sdk/ /p:SourceBuiltNonShippingPackagesDir=/vmr/artifacts/packages/Release/NonShipping/sdk/ > /vmr/artifacts/log/Release/sdk.log 2>&1" exited with code 1.
    ❌/vmr/src/sdk/src/Cli/dotnet/NugetPackageDownloader/NuGetPackageDownloader.cs(157,17): error CS1061: 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' does not contain a definition for 'GetAwaiter' and no accessible extension method 'GetAwaiter' accepting a first argument of type 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' could be found (are you missing a using directive or an assembly reference?)
    ❌expand to see the full error
      /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/SourceBuild/SourceBuildArcadeBuild.targets(130,5): error MSB3073: The command "/vmr/.dotnet//dotnet msbuild /m /nologo /clp:Summary /v:minimal /nr:false /warnaserror /p:TreatWarningsAsErrors=true /p:ContinuousIntegrationBuild=true /vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/Build.proj /bl:"/vmr/src/sdk/artifacts/log/Release/Build.binlog" /p:Configuration=Release /p:RepoRoot=/vmr/src/sdk/ /p:Restore=true /p:Build=true /p:DotNetBuildRepo=false /p:ArcadeBuildFromSource=false /p:DotNetBuildSourceOnly=false /p:Rebuild=false /p:Test=false /p:Pack=true /p:IntegrationTest=false /p:PerformanceTest=false /p:Sign=false /p:Publish=true /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=/vmr/artifacts/obj/sdk/NuGet.config /p:SourceBuiltAssetsDir=/vmr/artifacts/assets/Release/ /p:SourceBuiltAssetManifestsDir=/vmr/artifacts/obj/AssetManifests/sdk/ /p:PackageProjectUrl=https://github.com/dotnet/sdk /p:PortableRid=linux-x64 /p:TargetRid=linux-x64 /p:NETCoreAppMaximumVersion=99.9 /p:PortableOSName=linux /p:Rid=linux-x64 /p:Architecture=x64 /p:DOTNET_INSTALL_DIR=/vmr/.dotnet/ /p:AspNetCoreInstallerRid=linux-x64 /p:NetRuntimeRid=linux-x64 /p:SkipBuildingInstallers=true /p:PublicBaseURL=file:///vmr/artifacts/assets/Release/ /p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/ /p:UsePortableLinuxSharedFramework=false /p:SourceBuiltShippingPackagesDir=/vmr/artifacts/packages/Release/Shipping/sdk/ /p:SourceBuiltNonShippingPackagesDir=/vmr/artifacts/packages/Release/NonShipping/sdk/ -logger:/vmr/artifacts/source-built-sdks/Microsoft.DotNet.Arcade.Sdk/tools/net9.0/Microsoft.DotNet.ArcadeLogging.dll /p:DotNetBuildInnerRepo=true /p:DotNetBuildSourceOnly=false /p:RepoRoot="/vmr/src/sdk/" /p:ArtifactsDir="/vmr/src/sdk/artifacts/" /bl:"/vmr/src/sdk/artifacts/log/Release/source-inner-build.binlog" /p:ContinuousIntegrationBuild=true /p:SourceBuildOutputDir="/vmr/src/sdk/artifacts/sb/" /p:DotNetPackageVersionPropsPath="/vmr/artifacts/obj/PackageVersions/PackageVersions.sdk.props" /p:FullAssemblySigningSupported=false /p:DotNetPublishUsingPipelines=true /p:GitHubRepositoryName=sdk" exited with code 1.

sdk-unified-build / VMR Vertical Build / Windows_x64 / Build

[ 🚧 Report infrastructure issue] [ 📄 Report repository issue]
    ❌expand to see the full error
      repo-projects\Directory.Build.targets(428,5): error MSB3073: The command "D:\a\_work\1\vmr\src\sdk\eng\common\build.cmd -restore -build -pack -publish -ci -configuration Release -bl /p:DotNetBuildRepo=true /p:DotNetBuildOrchestrator=true /p:RestoreConfigFile=D:\a\_work\1\vmr\artifacts\obj\sdk\NuGet.config /p:SourceBuiltAssetsDir=D:\a\_work\1\vmr\artifacts\assets\Release\ /p:SourceBuiltAssetManifestsDir=D:\a\_work\1\vmr\artifacts\obj\AssetManifests\sdk\ -nativeToolsOnMachine /p:PackageProjectUrl=https://github.com/dotnet/sdk /p:PortableRid=win-x64 /p:TargetRid=win-x64 -v minimal /p:NETCoreAppMaximumVersion=99.9 /p:PortableOSName= /p:Rid=win-x64 /p:Architecture=x64 /p:DOTNET_INSTALL_DIR=D:\a\_work\1\vmr\.dotnet\ /p:PublicBaseURL=file://D:\a\_work\1\vmr\artifacts\assets\Release\ /p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/ /p:UsePortableLinuxSharedFramework=false -msbuildEngine dotnet /p:SourceBuiltShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\Shipping\sdk\ /p:SourceBuiltNonShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\NonShipping\sdk > D:\a\_work\1\vmr\artifacts\log\Release\sdk.log 2>&1" exited with code 1.
    ❌src\sdk\src\Cli\dotnet\NugetPackageDownloader\NuGetPackageDownloader.cs(157,17): error CS1061: 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' does not contain a definition for 'GetAwaiter' and no accessible extension method 'GetAwaiter' accepting a first argument of type 'ConfiguredTaskAwaitable<RepositorySignatureResource>?' could be found (are you missing a using directive or an assembly reference?)
    ❌expand to see the full error
      artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\SourceBuild\SourceBuildArcadeBuild.targets(130,5): error MSB3073: The command ""D:\a\_work\1\vmr\.dotnet\dotnet.exe" msbuild /m /nologo /clp:Summary /v:minimal /nr:False /p:ContinuousIntegrationBuild=True /warnaserror /p:TreatWarningsAsErrors=true "D:\a\_work\1\vmr\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk/tools/Build.proj" "/bl:D:\a\_work\1\vmr\src\sdk\artifacts\log\Release\Build.binlog" "/p:Configuration=Release" "/p:RepoRoot=D:\a\_work\1\vmr\src\sdk\\" "/p:Restore=True" "/p:DeployDeps=False" "/p:Build=True" "/p:Rebuild=False" "/p:Deploy=False" "/p:Test=False" "/p:Pack=True" "/p:DotNetBuildRepo=False" "/p:IntegrationTest=False" "/p:PerformanceTest=False" "/p:Sign=False" "/p:Publish=True" "/p:DotNetBuildRepo=true" "/p:DotNetBuildOrchestrator=true" "/p:RestoreConfigFile=D:\a\_work\1\vmr\artifacts\obj\sdk\NuGet.config" "/p:SourceBuiltAssetsDir=D:\a\_work\1\vmr\artifacts\assets\Release\\" "/p:SourceBuiltAssetManifestsDir=D:\a\_work\1\vmr\artifacts\obj\AssetManifests\sdk\\" "/p:PackageProjectUrl=https://github.com/dotnet/sdk" "/p:PortableRid=win-x64" "/p:TargetRid=win-x64" "/p:NETCoreAppMaximumVersion=99.9" "/p:PortableOSName=" "/p:Rid=win-x64" "/p:Architecture=x64" "/p:DOTNET_INSTALL_DIR=D:\a\_work\1\vmr\.dotnet\\" "/p:PublicBaseURL=file://D:\a\_work\1\vmr\artifacts\assets\Release\\" "/p:FallbackPublicBaseURL=https://dotnetbuilds.blob.core.windows.net/public/" "/p:UsePortableLinuxSharedFramework=false" "/p:SourceBuiltShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\Shipping\sdk\\" "/p:SourceBuiltNonShippingPackagesDir=D:\a\_work\1\vmr\artifacts\packages\Release\NonShipping\sdk" "/logger:D:\a\_work\1\vmr\artifacts\source-built-sdks\Microsoft.DotNet.Arcade.Sdk\tools\net9.0\Microsoft.DotNet.ArcadeLogging.dll" /p:DotNetBuildInnerRepo=true /p:RepoRoot="D:\a\_work\1\vmr\src\sdk\\" /p:ArtifactsDir="D:\a\_work\1\vmr\src\sdk\artifacts\\" /bl:"D:\a\_work\1\vmr\src\sdk\artifacts\log\Release\source-inner-build.binlog" /p:ContinuousIntegrationBuild=true /p:SourceBuildOutputDir="D:\a\_work\1\vmr\src\sdk\artifacts\sb\\" /p:DotNetPackageVersionPropsPath="D:\a\_work\1\vmr\artifacts\obj\PackageVersions\PackageVersions.sdk.props" /p:FullAssemblySigningSupported=false /p:DotNetPublishUsingPipelines=true /p:GitHubRepositoryName=sdk" exited with code 1.

1 other jobs are failing and were not displayed due to space limitations.
Builds with failures: [sdk-unified-build] [sdk-source-build]

Was this helpful? Yes No

View more details on Build Analysis