Changing TargetName in csproj breaks app host

[Symbai]

Description

When I set TargetName in csproj file and its different than AssemblyName it breaks the app host executable. If I open .deps.json file I can see that runtime dll file name is still named as AssemblyName.

Reproduction Steps

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net6.0-windows</TargetFramework>
    <Nullable>enable</Nullable>
    <UseWPF>true</UseWPF>
    <AssemblyName>1</AssemblyName>
    <TargetName>Test</TargetName>
  </PropertyGroup>

</Project>

Expected behavior

Building this project should generate the following files and the app should work.

Test.deps.json
Test.exe
Test.runtimeconfig.json
Test.dll

Actual behavior

Building this project generates the following files and the app doesnt work. I believe the app host executable is looking for 1.dll

1.deps.json
1.exe
1.runtimeconfig.json
Test.dll

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

Issue Details

---

Description

When I set TargetName in csproj file and its different than AssemblyName it breaks the app host executable. If I open .deps.json file I can see that runtime dll file name is still named as AssemblyName.

Reproduction Steps

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>WinExe</OutputType>
    <TargetFramework>net6.0-windows</TargetFramework>
    <Nullable>enable</Nullable>
    <UseWPF>true</UseWPF>
    <AssemblyName>1</AssemblyName>
    <TargetName>Test</TargetName>
  </PropertyGroup>

</Project>

Expected behavior

Building this project should generate the following files and the app should work.

Test.deps.json
Test.exe
Test.runtimeconfig.json
Test.dll

Actual behavior

Building this project generates the following files and the app doesnt work. I believe the app host executable is looking for 1.dll

1.deps.json
1.exe
1.runtimeconfig.json
Test.dll

Regression?

No response

Known Workarounds

No response

Configuration

No response

Other information

No response

Author:	Symbai
Assignees:	-
Labels:	area-Host
Milestone:	-

[elinor-fung]

SDK is using AssemblyName instead of TargetName

Generating deps/config:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines 65 to 68 in 7ae6329

	<ProjectDepsFileName Condition="'$(ProjectDepsFileName)' == ''">$(AssemblyName).deps.json</ProjectDepsFileName>
	<ProjectDepsFilePath Condition="'$(ProjectDepsFilePath)' == ''">$(TargetDir)$(ProjectDepsFileName)</ProjectDepsFilePath>
	<ProjectRuntimeConfigFileName Condition="'$(ProjectRuntimeConfigFileName)' == ''">$(AssemblyName).runtimeconfig.json</ProjectRuntimeConfigFileName>
	<ProjectRuntimeConfigFilePath Condition="'$(ProjectRuntimeConfigFilePath)' == ''">$(TargetDir)$(ProjectRuntimeConfigFileName)</ProjectRuntimeConfigFilePath>

Embedding binary name in apphost:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines 585 to 593 in 7ae6329

	<CreateAppHost AppHostSourcePath="$(AppHostSourcePath)"
	AppHostDestinationPath="$(AppHostIntermediatePath)"
	AppBinaryName="$(AssemblyName)$(TargetExt)"
	IntermediateAssembly="@(IntermediateAssembly->'%(FullPath)')"
	WindowsGraphicalUserInterface="$(_UseWindowsGraphicalUserInterface)"
	Retries="$(CopyRetryCount)"
	RetryDelayMilliseconds="$(CopyRetryDelayMilliseconds)"
	EnableMacOSCodeSign="$(_EnableMacOSCodeSign)"
	/>

Copying apphost to output:

sdk/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets

Lines 785 to 786 in 7ae6329

	<None Include="$(AppHostIntermediatePath)">
	<Link>$(AssemblyName)$(_NativeExecutableExtension)</Link>

[Symbai]

I'm sorry but I'm confused what you are trying to tell me with this. Do you want to let me know that its "by design"? Right now I can successfully build and end up with an app host which just silently crashes. So either its a bug in SDK and it must check for TargetName or, when its by design, I should get a build error at least. And if its by design, how else can I have a different assemblyname than filename? Because renaming files in explorer doesn't work (obviously).

[elinor-fung]

I'm sorry but I'm confused what you are trying to tell me with this. Do you want to let me know that its "by design"?

Ah, so sorry for the complete lack of context - should have said: The bug is that SDK is using AssemblyName instead of TargetName. It is a bug in the SDK. I just took a quick look and wanted to note the places I think we'd need to update for later reference, so pasted in the links.