Use uint.TryFormat to fix TODO in IPAddressParser #117300
Open
+8
−12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR replaces the manual digit-by-digit formatting of the IPv6 scope ID with a call to uint.TryFormat, removing the TODO and reducing code complexity.
- Added a
Debug.Assertto ensureTCharis eitherbyteorchar. - Replaced manual
stackallocformatting with a singleTryFormatcall for bothbyteandchar. - Removed the old loop-based formatting and related TODO comment.
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Primitives/src/System/Net/IPAddressParser.cs:225
- Add unit tests covering the new
TryFormatlogic for bothTChar = charandTChar = byteto ensure the IPv6 scope ID formatting is exercised in all scenarios.
bool formatted = typeof(TChar) == typeof(byte) ?
|
Tagging subscribers to this area: @dotnet/ncl |
MihaZupan
approved these changes
Jul 4, 2025
lilinus
reviewed
Jul 4, 2025
| used.CopyTo(destination.Slice(pos)); | ||
| pos += used.Length; | ||
| int bytesWritten; | ||
| bool formatted = typeof(TChar) == typeof(byte) ? |
There was a problem hiding this comment.
Do we want to switch to TryFormat in the local functions FormatByte and AppendHex in this file too?
This was referenced Jul 4, 2025
Open
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.