-
Notifications
You must be signed in to change notification settings - Fork 5.1k
Skip SSL key log test for OpenSSL 3.5+ #116474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip SSL key log test for OpenSSL 3.5+ #116474
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR skips the SSL key log file creation test when running against OpenSSL 3.5 or later, addressing false failures due to the library’s relaxed behavior.
- Updated SslStreamRemoteExecutorTests to bypass the test for OpenSSL versions 3.5+
- Added inline comments referencing the change and future revisit via issue #116473
Comments suppressed due to low confidence (1)
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs:37
- Consider using an explicit test skip attribute or helper instead of an early return to indicate that the test is intentionally skipped for OpenSSL 3.5+ scenarios. This approach can improve clarity in test reports and maintain consistency with other skipped tests.
if (PlatformDetection.IsOpenSslSupported && PlatformDetection.OpenSslVersion >= new Version(3, 5, 0))
Tagging subscribers to this area: @dotnet/ncl, @bartonjs, @vcsjones |
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
src/libraries/System.Net.Security/tests/FunctionalTests/SslStreamRemoteExecutorTests.cs
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
/backport to release/9.0-staging |
Started backporting to release/9.0-staging: https://github.com/dotnet/runtime/actions/runs/15679821163 |
Context
OpenSSL 3.5.0 supports SSLKEYLOGFILE with just an environment variable, which is less strict than .NET's requirements. There's no way to check if this feature is enabled in the OpenSSL library, so we should disable the test based on the OpenSSL version for now.
Affected tests
System.Net.Security.Tests.SslStreamRemoteExecutorTests.SslKeyLogFile_IsCreatedAndFilled
Testing
Fix verified on previously stable failing CentOS 10 docker image
mcr.microsoft.com/dotnet-buildtools/prereqs:centos-stream-10-helix-amd64
Notes
#116473 has been create to revisit it in future, lets say a year