Skip to content

[release/8.0-staging] Don't expose TrustedCertificatesDirectory() and StartNewTlsSessionContext() to NetFx #115008

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Apr 24, 2025

Backport of #113963 to release/8.0-staging

/cc @steveharter

v9 backport: #114995

Customer Impact

  • Customer reported
  • Found internally

Two recently added members are now removed from the NetStandard package so that a project targeting NetStandard will get a compile error if they try to use the members instead of a MissingMethodException if the members are called when running under .NET Framework.

Regression

  • Yes
  • No

Testing

Verified the NetStandard2.0 package does not contain:

  • LdapSessionOptions::get_TrustedCertificatesDirectory()
  • LdapSessionOptions::set_TrustedCertificatesDirectory()
  • LdapSessionOptions::StartNewTlsSessionContext()

Risk

Low. The method does not exist in the .NET Framework implementation, so we don't expose it in NetStandard.

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

@ghost
Copy link

ghost commented Apr 24, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Apr 24, 2025

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@steveharter steveharter self-assigned this Apr 24, 2025
@steveharter steveharter requested review from ericstj and artl93 April 24, 2025 20:14
@steveharter steveharter added Servicing-consider Issue for next servicing release review and removed new-api-needs-documentation labels Apr 24, 2025
@steveharter steveharter added this to the 8.0.x milestone Apr 24, 2025
@rbhanda rbhanda modified the milestones: 8.0.x, 8.0.17 Apr 29, 2025
@rbhanda rbhanda added Servicing-approved Approved for servicing release and removed Servicing-consider Issue for next servicing release review labels Apr 29, 2025
@ericstj ericstj added the breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. label Apr 29, 2025
@dotnet-policy-service dotnet-policy-service bot added the needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet label Apr 29, 2025
Copy link
Contributor

Added needs-breaking-change-doc-created label because this PR has the breaking-change label.

When you commit this breaking change:

  1. Create and link to this PR and the issue a matching issue in the dotnet/docs repo using the breaking change documentation template, then remove this needs-breaking-change-doc-created label.
  2. Ask a committer to mail the .NET Breaking Change Notification DL.

Tagging @dotnet/compat for awareness of the breaking change.

@ericstj
Copy link
Member

ericstj commented Apr 29, 2025

@steveharter, let's add a breaking change doc around this, even though it was only out there for a couple months. That will help folks realize that it's intentional.

@vseanreesermsft vseanreesermsft added Servicing-consider Issue for next servicing release review and removed Servicing-consider Issue for next servicing release review labels May 2, 2025
@steveharter
Copy link
Member

/ba-g unrelated System.Globalization.Tests failures

@steveharter steveharter merged commit 64c2e18 into release/8.0-staging May 7, 2025
126 of 133 checks passed
@steveharter steveharter deleted the backport/pr-113963-to-release/8.0-staging branch May 7, 2025 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-System.DirectoryServices breaking-change Issue or PR that represents a breaking API or functional change over a prerelease. needs-breaking-change-doc-created Breaking changes need an issue opened with https://github.com/dotnet/docs/issues/new?template=dotnet Servicing-approved Approved for servicing release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants