Disable stacks on Debugger IPC events #114585
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Tagging subscribers to this area: @tommcdon |
Do we know why it crashes? Its not obvious to me why a crash in stackwalking would only be a problem for debugger related ETW events rather than all ETW events. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have received complaints from internal teams that app can crash when entering break state with Debugger IPC ETW events enabled. I was able to reproduce the issue by using perfview to enable .NET ETW events, F5 a .NET Core, and enter break state by hitting a breakpoint. The root issue is related to stackwalking on the Debugger IPC event causing a crash in the runtime. As the stack traces on Debugger IPC events is not useful in any production scenario, this PR disables the stackwalk on the IPC event.