[release/9.0-staging] Fix inadvertently upgrading compiler warnings to errors #114331
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed this while looking at an issue in the 9.0 branch with latest clang which runs into a couple warnings fixed in main with dotnet#108888. We intentionally don't set `-Werror` in release branches to avoid breaking the build when newer compilers add warnings via https://github.com/dotnet/runtime/blob/37e4d45236e68946db9d264593aa31a9c00534bc/eng/native/configurecompiler.cmake#L564-L567 However this didn't work because msbuild's WarnAsError was still reading the console output of the native build and upgrading any line with "warning: " to an msbuild error and breaking the build. Suppress this by setting IgnoreStandardErrorWarningFormat="true" on the Exec call. We already did this in the coreclr and mono runtime builds, we just missed it in libs.native.
|
Applying servicing-approved, infrastructure-only change required to build with newer compilers, tell mode. |
|
Tagging subscribers to this area: @dotnet/area-infrastructure-libraries |
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
akoeplinger
changed the title
This comment was marked as outdated.
This comment was marked as outdated.
ViktorHofer
approved these changes
Apr 7, 2025
|
/ba-g wasm failures are due to using a not-yet-published .net version, unrelated |
akoeplinger
merged commit 5407686
into
dotnet:release/9.0-staging
107 of 112 checks passed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114323 to release/9.0-staging.
Don't inadvertently upgrade compiler warnings to errors in libs.native.
Customer Impact
Building with a newer compilers can introduce new warnings, breaking the build unintentionally even though we explicitly tried to avoid this by disabling this behavior in release branches. This could especially affect source-build partners which don't use our build infrastructure.
Regression
No, we just forgot to apply this fix to the libs.native subset. It was there for coreclr and mono runtime builds already.
Testing
CI testing.
Risk
Low, this is a build-only change.