Skip to content

[release/8.0-staging] Fix build break with cmake 4.0 #114279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 4, 2025
Merged

[release/8.0-staging] Fix build break with cmake 4.0 #114279

merged 1 commit into from
Apr 4, 2025

Conversation

akoeplinger
Copy link
Member

Backport of #114277 to release/8.0-staging

/cc @akoeplinger

Customer Impact

  • Customer reported
  • Found internally

This is an infrastructure/build-only change and required for us to build with cmake 4.0+.

Regression

  • Yes
  • No

No, it was caused by a change in cmake 4.0

Testing

CI testing

Risk

Low. This is a build-only change.

@Copilot Copilot AI review requested due to automatic review settings April 4, 2025 18:44
Copilot
Copilot AI reviewed Apr 4, 2025
View reviewed changes
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot wasn't able to review any files in this pull request.

Files not reviewed (1)
  • src/native/libs/System.Security.Cryptography.Native.Apple/CMakeLists.txt: Language not supported

@ghost ghost added the area-System.Security label Apr 4, 2025
@akoeplinger
Copy link
Member Author

Infra change required to build. Tell mode. Applying servicing-approved.

@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-infrastructure-libraries
See info in area-owners.md if you want to be subscribed.

@akoeplinger akoeplinger merged commit 5738cb8 into release/8.0-staging Apr 4, 2025
130 of 132 checks passed
@akoeplinger akoeplinger deleted the 8.0-fix-cmake-break branch April 4, 2025 22:56
@github-actions github-actions bot locked and limited conversation to collaborators May 5, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

Copilot code review Copilot Copilot left review comments

@lewing lewing lewing approved these changes

Assignees

@akoeplinger akoeplinger

Labels
area-Infrastructure-libraries Servicing-approved Approved for servicing release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akoeplinger @lewing