-
Notifications
You must be signed in to change notification settings - Fork 5k
[release/8.0] Revert disabling of tests for HTTP servers #114209
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release/8.0] Revert disabling of tests for HTTP servers #114209
Conversation
…11.azure…" This reverts commit 7bdb3db.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This pull request reverts previous changes that disabled tests for HTTP servers, re-enabling various test paths for HTTP and HTTPS endpoints. Key changes include:
- Reverting URI references in tests to use the appropriate non-secure and secure endpoints.
- Removing ActiveIssue attributes to re-enable tests across multiple files.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
File | Description |
---|---|
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/WinHttpHandlerTest.cs | Updated URI for redirection tests to use RemoteHttp11Server and RemoteEchoServer |
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/ServerCertificateTest.cs | Removed ActiveIssue attribute to re-enable certificate tests |
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.ServerCertificates.cs | Removed ActiveIssue attribute for non-secure connection callback tests |
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs | Updated endpoints and formatting to revert to original server references |
src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs | Updated EchoServers and EchoHeadersServers definition to include all endpoints |
src/libraries/Common/tests/System/Net/Configuration.Http.cs | Re-enabled references to RemoteEchoServer/RemoteVerifyUploadServer and updated RemoteServers array |
Comments suppressed due to low confidence (7)
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/WinHttpHandlerTest.cs:58
- Ensure that the updated server endpoint correctly targets the non-secure HTTP scenario and that the endpoint is available in the test environment.
Uri uri = System.Net.Test.Common.Configuration.Http.RemoteHttp11Server.RedirectUriForDestinationUri(302, System.Net.Test.Common.Configuration.Http.RemoteEchoServer, 1);
src/libraries/System.Net.Http.WinHttpHandler/tests/FunctionalTests/ServerCertificateTest.cs:34
- Confirm that removing the ActiveIssue attribute does not introduce intermittent failures during test runs.
[ActiveIssue("https://github.com/dotnet/runtime/issues/110578")]
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs:74
- Verify that the updated URI properly supports authentication scenarios for non-secure connections in the test environment.
Uri uri = Configuration.Http.RemoteHttp11Server.NegotiateAuthUriForDefaultCreds;
src/libraries/Common/tests/System/Net/Http/HttpClientHandlerTest.RemoteServer.cs:1073
- Ensure that switching the endpoint to RemoteHttp11Server aligns with the expected redirection behavior in the tests.
Task<HttpResponseMessage> t = client.GetAsync(Configuration.Http.RemoteHttp11Server.RedirectUriForDestinationUri(
src/libraries/Common/tests/System/Net/Configuration.WebSockets.cs:25
- Confirm that including both RemoteEchoServer and SecureRemoteEchoServer provides the intended coverage for WebSocket echo functionality.
public static readonly object[][] EchoServers = { new object[] { RemoteEchoServer }, new object[] { SecureRemoteEchoServer } };
src/libraries/Common/tests/System/Net/Configuration.Http.cs:61
- Ensure that including RemoteEchoServer in the EchoServerList is intentional and that all referenced URIs are valid and active.
public static readonly Uri[] EchoServerList = new Uri[] { RemoteEchoServer, SecureRemoteEchoServer, Http2RemoteEchoServer };
src/libraries/Common/tests/System/Net/Configuration.Http.cs:87
- Verify that the updated RemoteServers array accurately represents all the intended test servers for different HTTP scenarios.
public static readonly IEnumerable<RemoteServer> RemoteServers = new RemoteServer[] { RemoteHttp11Server, RemoteSecureHttp11Server, RemoteHttp2Server };
/azp run runtime-libraries-coreclr outerloop |
Azure Pipelines successfully started running 1 pipeline(s). |
Tagging subscribers to this area: @dotnet/ncl |
Test-only change -> tell-mode |
/ba-g CI failures are unrelated |
Manual ackport of #114196 to release/8.0-staging
/cc @rzikm
Customer Impact
None, test only change
Regression
No
Testing
CI run passes
Risk
Low, test-only change