[9.0] Bring back yml necessary change types in label checkers #114166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlossanlop
added
Servicing-approved
carlossanlop
requested review from
akoeplinger,
jkoritzinsky,
ViktorHofer and
hoyosjs
There was a problem hiding this comment.
Pull Request Overview
This PR is a backport to reinstate necessary event types for pull request label checking in GitHub workflows.
- Adds "edited" and "synchronize" event triggers in check-service-labels.yml.
- Updates check-no-merge-label.yml similarly to ensure the labeler continues to work with updated PR events.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| .github/workflows/check-service-labels.yml | Added "edited" and "synchronize" event types for enhanced PR event handling. |
| .github/workflows/check-no-merge-label.yml | Added "edited" and "synchronize" event types to maintain consistency in PR label checking. |
|
Tagging subscribers to this area: @dotnet/runtime-infrastructure |
hoyosjs
approved these changes
Apr 2, 2025
jkoritzinsky
approved these changes
Apr 2, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #114165
Tell mode.
There are some
on pull_request_target typesin the label checking yml files that I removed but they are actually necessary, so the labeler keeps working after for example: pushing new commits, pressing the update the branch, closing and opening the PR.