You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The following disabled tests are specific to CoreCLR Android:
Microsoft.VisualBasic.Tests.ErrObjectTests.Clear
MonoTests.System.Configuration.mapped_ExeConfiguration_null
MonoTests.System.Configuration.OpenExeConfiguration1_UserLevel_None
System.Threading.Tests.MutexTests - add a process-wide implementation of named mutex to CoreCLR on Mono to better compatibility with Mono
System.IO.Pipelines.Tests.CompleteWithLargeWriteThrows
With the number of disabled tests exclusively for coreclr, it feels like Android on one runtime flavor is less capable than the other. Ideally, we shouldn't need to disable any test which wasn't disabled on mono; i.e. just the $(TargetOS) == Android && $(RuntimeFlavor) == Mono to $(TargetFlavor) == Android type of updates. Can we work those differences out?
Some of the tests disabled in tests.proj are re-enabled in this PR because they are now passing in CI and updating conditions from $(TargetOS) == Android && $(RuntimeFlavor) == Mono to $(TargetFlavor) == Android wouldn't be sufficient. The changes made in this PR are necessary for those tests to run correctly on both Mono and CoreCLR. Reverting to the previous test-specific annotations would reduce the number of passing tests.
I have listed the failures that are specific to CoreCLR on Android. The remaining failures are due to a globalization issue or the Assembly.Location limitation in singlefilehost scenarios.
The number of test projects sent to helix on mono Android arm64 has increased from 217 to 243.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
kotlarmilos
added
NO-MERGE
Description
This PR enables running CoreCLR library tests on the Android emulators and devices and adds a script for local testing on Windows.
Changes
Disabled tests fall into two categories.
Globalization or other mobile‐platform issues
These tests have been disabled because they depend on invariant‐culture behaviors or platform APIs that aren’t fully supported on mobile targets:
CoreCLR Android-specific failures
The following disabled tests are specific to CoreCLR Android:
Closes #50871 #50874 #50923 #49937