Skip to content

[release/10.0-preview3] Revert "Refactor external_assembly_probe to be separate from single-file bundle probing" #113746

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

github-actions[bot]
Copy link
Contributor

Backport of #113738 to release/10.0-preview3

/cc @agocke

Customer Impact

  • Customer reported
  • Found internally

[Select one or both of the boxes. Describe how this issue impacts customers, citing the expected and actual behaviors and scope of the issue. If customer-reported, provide the issue number.]

Regression

  • Yes
  • No

[If yes, specify when the regression was introduced. Provide the PR or commit if known.]

Testing

[How was the fix verified? How was the issue missed previously? What tests were added?]

Risk

[High/Medium/Low. Justify the indication by mentioning how risks were measured and addressed.]

IMPORTANT: If this backport is for a servicing release, please verify that:

  • The PR target branch is release/X.0-staging, not release/X.0.

Package authoring no longer needed in .NET 9

IMPORTANT: Starting with .NET 9, you no longer need to edit a NuGet package's csproj to enable building and bump the version.
Keep in mind that we still need package authoring in .NET 8 and older versions.

Copy link
Contributor

Tagging subscribers to this area: @vitek-karas, @agocke, @VSadov
See info in area-owners.md if you want to be subscribed.

@agocke agocke added the Servicing-approved Approved for servicing release label Mar 20, 2025
@agocke
Copy link
Member

agocke commented Mar 20, 2025

@ViktorHofer @jeffschwMSFT

@agocke
Copy link
Member

agocke commented Mar 21, 2025

Failing test on MacOS is MSQuic -- I think it's unrelated.

@jeffschwMSFT I think this is ready to go.

@jeffschwMSFT jeffschwMSFT merged commit 0a33e18 into release/10.0-preview3 Mar 21, 2025
95 of 99 checks passed
@agocke agocke deleted the backport/pr-113738-to-release/10.0-preview3 branch March 21, 2025 17:29
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants