Skip to content

JIT: fix arm64 issue around flags and neg with contained operand #113391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 12, 2025
Merged

JIT: fix arm64 issue around flags and neg with contained operand #113391

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8fc0e4c
JIT: fix arm64 issue around flags and neg with contained operand
AndyAyersMS Mar 11, 2025
3fe62bf
somehow lost and endif; add test proj
AndyAyersMS Mar 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/coreclr/jit/gentree.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19978,12 +19978,17 @@ bool GenTree::SupportsSettingZeroFlag()
}
#endif
#elif defined(TARGET_ARM64)
if (OperIs(GT_AND, GT_AND_NOT, GT_NEG))
if (OperIs(GT_AND, GT_AND_NOT))
{
return true;
}

// We do not support setting zero flag for madd/msub.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// We do not support setting zero flag for madd/msub.
// We do not support setting zero flag for mneg/madd/msub.

feel free to skip to avoid CI rerun...

if (OperIs(GT_NEG) && (!gtGetOp1()->OperIs(GT_MUL) || !gtGetOp1()->isContained()))
Copy link
Member

@EgorBo EgorBo Mar 11, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I presume just if (OperIs(GT_NEG) && !gtGetOp1()->isContained()) would be enough since NEG can't contain anything. Also, we should've had a separate node type for MUL+ADD/SUB (likely my fault)

{
return true;
}

if (OperIs(GT_ADD, GT_SUB) && (!gtGetOp2()->OperIs(GT_MUL) || !gtGetOp2()->isContained()))
{
return true;
Expand Down
36 changes: 36 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_113320/Runtime_113320.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,36 @@
// Licensed to the .NET Foundation under one or more agreements.
// The .NET Foundation licenses this file to you under the MIT license.

// Generated by Fuzzlyn v2.4 on 2025-03-09 16:30:39
// Run on Arm64 Linux
// Seed: 8543882715922286200-vectort,vector64,vector128,armadvsimd,armadvsimdarm64,armaes,armarmbase,armarmbasearm64,armcrc32,armcrc32arm64,armdp,armrdm,armrdmarm64,armsha1,armsha256,armsve
// Reduced from 59.2 KiB to 0.4 KiB in 00:00:34
// Debug: Outputs 0
// Release: Outputs 1
using System;
using System.Numerics;
using System.Runtime.Intrinsics;
using System.Runtime.Intrinsics.Arm;
using Xunit;

public class Runtime_113320
{
public static ushort s_12;
public static uint[, ] s_13 = new uint[, ]
{
{
1
}
};

[Fact]
public static int Problem()
{
if (((0 % s_13[0, 0]) > 0))
{
s_12 = 1;
}

return s_12 + 100;
}
}
8 changes: 8 additions & 0 deletions src/tests/JIT/Regression/JitBlue/Runtime_113320/Runtime_113320.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
<Project Sdk="Microsoft.NET.Sdk">
<PropertyGroup>
<Optimize>True</Optimize>
</PropertyGroup>
<ItemGroup>
<Compile Include="$(MSBuildProjectName).cs" />
</ItemGroup>
</Project>
Loading