Disable newly added test on native AOT and drop RequiresProcessIsolation #112095
Conversation
ghost
added
the
needs-area-label
| <AllowUnsafeBlocks>true</AllowUnsafeBlocks> | ||
| <CLRTestPriority>1</CLRTestPriority> | ||
| <CLRTestTargetUnsupported Condition="'$(TargetOS)' != 'windows'">true</CLRTestTargetUnsupported> | ||
| <!-- Testing a backwards compatibility quirk we don't officially support --> | ||
| <NativeAotIncompatible>true</NativeAotIncompatible> | ||
| </PropertyGroup> | ||
| <PropertyGroup> |
There was a problem hiding this comment.
Btw, was this part intentional, or a random copypaste? Optimize=true will make it so that we never run this tests without JIT optimizations enabled. The JIT team sometimes does things like this because they want mulitple variants (they have the _d, _ro, etc. variants).
This test doesn't have variants. This EH teste should ideally also work with optimizations disabled, right?
There was a problem hiding this comment.
I am confused - don't we need the RequiresProcessIsolation for the cases when there is a native part of the test built via cmake?
There was a problem hiding this comment.
Ah, ok, then it is fine to remove.
|
/azp run runtime-outerloop |
|
No pipelines are associated with this pull request. |
|
/azp list |
|
/azp run runtime-coreclr outerloop |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
I ended up having to keep the RequiresProcessIsolation because the test started running and failing on Linux. Turns out process isolation is needed for CLRTestTargetUnsupported. I updated the comment to say that. |
CMakeProjectReference is not a reason to add RequiresProcessIsolation, I've been deleting those for a while (e.g. #111406).