Skip to content

Add TimeSpan.FromMilliseconds(long) overload #110234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2024
Merged

Add TimeSpan.FromMilliseconds(long) overload #110234

merged 1 commit into from
Nov 28, 2024

Conversation

tarekgh
Copy link
Member

@tarekgh tarekgh commented Nov 27, 2024

Fixes #109833

Related issue #93890 (comment)

@ghost ghost added needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners new-api-needs-documentation labels Nov 27, 2024
@ghost
Copy link

ghost commented Nov 27, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

1 similar comment
@ghost
Copy link

ghost commented Nov 27, 2024

Note regarding the new-api-needs-documentation label:

This serves as a reminder for when your PR is modifying a ref *.cs file and adding/modifying public APIs, please make sure the API implementation in the src *.cs file is documented with triple slash comments, so the PR reviewers can sign off that change.

@tarekgh tarekgh added area-System.DateTime and removed needs-area-label An area label is needed to ensure this gets routed to the appropriate area owners labels Nov 27, 2024
@tarekgh tarekgh added this to the 10.0.0 milestone Nov 27, 2024
@build-analysis build-analysis bot mentioned this pull request Nov 27, 2024
Open
@tarekgh tarekgh merged commit af3393d into dotnet:main Nov 28, 2024
139 checks passed
mikelle-rogers pushed a commit to mikelle-rogers/runtime that referenced this pull request Dec 10, 2024
@tarekgh @mikelle-rogers
Add TimeSpan.FromMilliseconds(long) overload (dotnet#110234)
f5bb28e
@MichalStrehovsky MichalStrehovsky mentioned this pull request Dec 13, 2024
Merged
4 tasks
@github-actions github-actions bot locked and limited conversation to collaborators Dec 28, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tannergooding tannergooding tannergooding approved these changes

Assignees

@tarekgh tarekgh

Labels
area-System.DateTime new-api-needs-documentation
Projects
None yet
Milestone
10.0.0
Development

Successfully merging this pull request may close these issues.

The new TimeSpan FromMilliseconds overload breaks System.Linq.Expressions
2 participants
@tarekgh @tannergooding