Skip to content

[cdac] Remove extra [] in array type name #106662

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 20, 2024

Conversation

elinor-fung
Copy link
Member

We were appending an extra [] to the end of the type name for multi-dimensional or non-zero-based arrays.

Examples:

// int[,]
-System.Int32[,][]
+System.Int32[,]
// long[,,]
-System.Int64[,,][]
+System.Int64[,,]
// Array.CreateInstance(typeof(uint), [5], [1])
-System.UInt32<*>[]
+System.UInt32<*>
// ulong[,][]
-System.UInt64[][,][]
+System.UInt64[][,]

Copy link
Contributor

Tagging subscribers to this area: @tommcdon
See info in area-owners.md if you want to be subscribed.

@elinor-fung elinor-fung merged commit 7f2357f into dotnet:main Aug 20, 2024
145 of 149 checks passed
@elinor-fung elinor-fung deleted the cdac-array-name branch August 20, 2024 15:17
@github-actions github-actions bot locked and limited conversation to collaborators Sep 20, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants