Skip to content

Add docs on how to build *.nupkg packages #1110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from

Conversation

bdovaz
Copy link
Contributor

@bdovaz bdovaz commented Jul 11, 2023

No description provided.

@josefpihrt
Copy link
Collaborator

I'm going to finally add workflow in #1112 which makes this PR obsolete.

But thanks anyway.

@josefpihrt josefpihrt closed this Jul 14, 2023
@bdovaz
Copy link
Contributor Author

bdovaz commented Jul 14, 2023

@josefpihrt Actually, my PR is equally valid because I'm talking about making a build locally for someone who does a fork, the workflow I imagine involves publishing the package, etc.

@josefpihrt
Copy link
Collaborator

josefpihrt commented Jul 15, 2023

I'm not against adding documentation of any kind if it's helpful.

As of now, I use powershell scripts to build "Release" artifacts. When #1112 is merged all artifacts will be available through GH Actions which is convenient. All "Release" scripts will be removed.

If you want to build something locally (without creating a PR that will trigger the workflow), you can just build it inside Visual Studio or run dotnet pack. I think that it's obvious and it does not need to be documented.

If you still want to add some documentation I'm fine with it but please discuss what and how it should be documented.

@bdovaz bdovaz deleted the feature/improve-docs branch August 20, 2023 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants