Remove the 'intent' subsystem from roslyn #79179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pgroene for visibility as well. |
jasonmalinowski
approved these changes
Jun 27, 2025
| @@ -28,7 +27,7 @@ internal interface IIntentSourceProvider | |||
| internal readonly struct IntentRequestContext(string intentName, SnapshotSpan currentSnapshotSpan, ImmutableArray<TextChange> textEditsToPrior, TextSpan priorSelection, string? intentData) | |||
There was a problem hiding this comment.
Is this code already dead, so it's just a matter of time of deleting the code from the callers too?
|
We are still using the intents. This would block us from upgrading to the Newest Roslyn version if needed. |
|
Gotcha. Sorry for the misunderstanding. I will restore. |
CyrusNajmabadi
added a commit
to CyrusNajmabadi/roslyn
that referenced
this pull request
Jun 30, 2025
333fred
added a commit
that referenced
this pull request
Jun 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
this was an early ML subsystem that predates copillot. We are not continuing this experiment.