[REDO] Ensure the LSP server is loaded after a solution is closed #79126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
3 tasks
davidwengier
force-pushed
the
StartLSPServerOnSolutionOpenTakeTwo
branch
2 times, most recently
from
66b88b4 to
6654dc1
Compare
davidwengier
force-pushed
the
StartLSPServerOnSolutionOpenTakeTwo
branch
from
b76b070 to
6b34e40
Compare
|
Speedometer run was green, so marking this ready for review.: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/647470 Kicked it off a second time to be sure, and that was also green, though it posted to a completely different insertion PR 🤷♂️ |
src/EditorFeatures/Core/LanguageServer/AlwaysActiveLanguageClientEventListener.cs
Outdated
Show resolved
Hide resolved
CyrusNajmabadi
approved these changes
Jul 1, 2025
ToddGrun
added a commit
to ToddGrun/roslyn
that referenced
this pull request
Jul 10, 2025
…osed (dotnet#79126)" This reverts commit fda66cf, reversing changes made to f10909a.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Redo of #79048 with a minor tweak to try to prevent the completion test flakiness that caused the revert in #79125