Support extension operators in Linq Expression Trees #78942
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlekseyTs
added
Area-Compilers
Feature - Extension Everything
jjonescz
approved these changes
Jun 13, 2025
| { | ||
| // PROTOTYPE: Communicate to LDM | ||
| // An expression tree factory isn't happy in this case. It throws | ||
| // System.ArgumentException : The user-defined operator method 'op_BitwiseOr' for operator 'OrElse' must have associated boolean True and False operators. |
There was a problem hiding this comment.
Would it work if there were corresponding op_True and op_False operators also defined in the extension class? #Resolved
There was a problem hiding this comment.
Would it work if there were corresponding
op_Trueandop_Falseoperators also defined in the extension class?
We wouldn't get here if there were not.
| } | ||
| } | ||
|
|
||
| // PROTOTYPE: Test unsafe and partial, IOperation/CFG , Linq expression tree, Nullable analysis | ||
| // Assert result of operator for basic consumption scenarios | ||
| // Cover ErrorCode.ERR_ExtensionDisallowsMember for conversion operators | ||
| // Ref safety analysis? | ||
| // "An extension operator may not have the same signature as a predefined operator." not yet implemented |
There was a problem hiding this comment.
Why was this prototype comment removed? #Resolved
There was a problem hiding this comment.
Why was this prototype comment removed?
LDM decided on Monday to drop this rule.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to test plan #76130