Extensions: use specific tracking issues for different areas #78834
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcouv
added
Area-Compilers
Feature - Extension Everything
|
FYI @jaredpar |
jaredpar
approved these changes
Jun 5, 2025
AlekseyTs
reviewed
Jun 6, 2025
| @@ -1725,7 +1725,7 @@ private void ValidateIndexerNameAttribute(CSharpAttributeData attribute, Attribu | |||
| } | |||
| else if (this.GetIsNewExtensionMember() && SourceName != indexerName) | |||
| { | |||
| // Tracked by https://github.com/dotnet/roslyn/issues/76130 : Report more descriptive error | |||
| // Tracked by https://github.com/dotnet/roslyn/issues/78830 : diagnostic quality, Report more descriptive error | |||
There was a problem hiding this comment.
// Tracked by #78830 : diagnostic quality, Report more descriptive error
Should this go into the indexers bucket instead?
This was referenced Jun 10, 2025
333fred
added a commit
that referenced
this pull request
Jun 17, 2025
* Simpli * Simplify * Simplify * docs * docs * Clear * Update src/Workspaces/Core/Portable/FindSymbols/Shared/AbstractSyntaxIndex_Persistence.cs * Remove method * Fix ILBuilder visualization (#78764) Turns out that we do have visualization of in-progress IL building, but it's been broken since 2020, when we renamed Roslyn.Test.Utilities to Microsoft.CodeAnalysis.Test.Utilities. It was then further broken by the change a few months ago to pass IL visualization formats along. This gets the debugger display working again. * Remove EditorFeaturesWpf TestComposition (#78769) After the EditorFeatures.WPF => EditorFeatures refactoring, this TestComposition became equivalent to the EditorFeatures one, so just removing the WPF one. * Fix renames across different extensions * Add docs * Add docs * Update src/VisualStudio/Core/Def/PackageRegistration.pkgdef * Explicitly reset * Reset state * Add docs * Simplify * Revert * Simplify * Simplify * Docs * Update src/VisualStudio/Core/Def/Commands.vsct Co-authored-by: David Barbet <[email protected]> * Update src/VisualStudio/Core/Impl/SolutionExplorer/SymbolTree/SymbolItemContextMenuController.cs Co-authored-by: David Barbet <[email protected]> * Simplify * Simplify * multi notify * only if it changed * Don't move backwards * Docs * Update src/VisualStudio/Core/Impl/SolutionExplorer/SymbolTree/SymbolTreeChildCollection.cs * Ensure sln load uses project absolute paths * lint * Rename field to make it clearer what it's used for It's only for dynamic files, so make that clear. * Don't refresh dynamic files under a lock When we were getting the notification of a dynamic file being changed, we were taking the project and workspace locks before fetching the actual content. This is really expensive now that the fetching itself might not be instant. Fundamentally this change is just switching the work to acquire the locks to get the setup info, then releasing the locks and calling the provider to get the info. I'm putting this around a batching queue so we can deduplicate lots of events at once, and also to ensure ordering so if we were to try refreshing the document more than once we don't end up in a case where we have two threads trying to put different versions of the document into the workspace and getting the ordering wrong. Fixes #78734 * Fix cast before we unsubscribe This was otherwise throwing an exception every shutdown. * Adjust implementation to respect diagnostic flag and update tests * Remove workarounds for bugs that have been fixed Closes #77995 * Remove a workaround we had for an old version of Copilot This bug was fixed a long time ago. * Switch return to continue * Fixed multi-variable declaration support in RemoveUnnecessarySuppressions. * Removed whitespace. Co-authored-by: DoctorKrolic <[email protected]> * Simplified TestRemoveDiagnosticSuppression_Attribute_MultiVariableDeclaration with inline data. * Expanded remove unnecessary suppression tests, removed unnecessary loop and fixed partial method/property support in AbstractRemoveUnnecessaryInlineSuppressionsDiagnosticAnalyzer. * Directly create virtual project when dotnet run-api is missing for now * Avoid dereferencing null CheckConstraintsArgs.CurrentCompilation (#78729) Fixes #78430. * Updates to unblock dartlab pipeline (#78793) * update timeout * wip * Add main to main-vs-deps flow (#78798) * Create branch-merge2.jsonc * Update main-merge.yml * Rename branch-merge2.jsonc to branch-merge-2.jsonc * Update PublishData.json * Update and rename branch-merge.jsonc to main-to-main-vs-deps-branch-merge.jsonc * feedbacl * make clear main is for validation * EnC: Simplify diagnostic reporting (#78708) * Refactoring of extension methods in source packages (#78620) * Change namespace of OneOrMany and TemporaryArray to MS.CA.Collections * Cleanup Enumerable and ImmutableArray extensions * Update imports/usings * Fix VB remove-imports not showing up * add the schedule back to main-merge (#78807) * Fix LSP references for using alias * Clean up HasDuplicates extension method (#78808) * Extensions: Do not consider extension block methods as entry points, consider their implementation methods instead (#78667) * Decouple EditorFeatures.Test.Utilities from VS services Microsoft.CodeAnalysis.EditorFeatures.Test.Utilities depended on Microsoft.VisualStudio.Editor which brought along various VS layer services. Further, we had some stub implementations of those VS services there. Digging into this this coupling wasn't really necessary: 1. There were EditorFeatures tests using the editor adapters stub, but those tests pass just fine without it, so that was easy to move to the VS specific tests. 2. StubVsServiceExporters didn't appear to be used either, so unsure why those were in this layer at all. Those were also moved. 3. We had implementations of some settings services, which it's easier to just delete and remove the options persister from the composition in the first place. This also better ensures that we don't have code that might try creating registry keys from ILocalRegistry which we absolutely don't want. * Extensions: mark skeleton type with 'specialname' (#78690) * Fix await completion in an async iterator * Extensions: fix lowering of implicit conversion on receiver in pattern-based scenarios (#78685) * Add test * Find metadata reference for alias * Add a fallback path when launching the BuildHost * refactor * Added notes to update GetBuildHostPath if packaging changes * Update comments * Add heuristic for the loaded from nuget package scenario * Fix corruption of sliding text window when trying to peek backwards. (#78774) Co-authored-by: Fred Silberberg <[email protected]> * Track changed text instead of clearing immediate window. * EnC: Partial solution updates (#78744) * Restore some parts of the progression api some legacy components (like codemap) use. * Remove unused internal APIs * Remove unused internal APIs * Remove unused internal APIs * Remove unused internal APIs * Make static * Simplify * Avoid ignored directive errors in disabled regions (#78158) * Extensions: use specific tracking issues for different areas (#78834) * Extensions: relax inferrability rule (#78758) * Remove blank line output from the node writer proportional to the number of non-abstract nodes (#78844) * Revert "Refactoring of extension methods in source packages (#78620)" (#78850) This reverts commit 917401d, broke typescript * Switch off of mutlidictionary (#78851) This is from ICSharpCompiler, and is therefore causing unnecessary dll loads. * Switch behavior of "Go to definition" and "Go to implementation" for partial members * Fix LSP tests * Fix peek test * Switch to existing helpers for multi-dictionary use * call TryGetValue to get dictionary entry (#78863) * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Add VSTypeScriptAsynchronousTaggerProvider2 for TypeScript that avoids TemporaryArray (#78866) * Remove more progression code * Remove more progression code * Remove more progression code * Remove more progression code * Fix build break (#78870) * Add more ETW events to trace assembly loading (#78840) * Add more ETW events to trace assembly loading * Update src/Compilers/Core/Portable/CodeAnalysisEventSource.Common.cs Co-authored-by: Joey Robichaud <[email protected]> * Put correct alc reference * Use binary literals --------- Co-authored-by: Joey Robichaud <[email protected]> * Introduce EA layer for TS to integrate with classification * Simplify * Add CommandLineResource API (#78679) * Revert "Revert "Refactoring of extension methods in source packages (#78620)" (#78850)" This reverts commit e083be9. * Fix * Revert "Fix" This reverts commit 574935d. * Revert "Revert "Revert "Refactoring of extension methods in source packages (#78620)" (#78850)"" This reverts commit 27ae586. * Lint * Remove all progression code * Revert * remove code * Fix * Reduce allocations under ContextMutableIntervalTree (#78885) There are some closure allocations unnecessarilly happening during ContextMutableIntervalTree construction. Simply changed a couple methods to static and added a parameter for the extra bit of data they need to get rid of those allocations. This is a very small improvement, only about 0.1% (6 MB) of allocations during typing in the razor speedometer test. * Reduce allocations in the ImageElementConverter and ImageIdConverter Read methods (#78881) * Reduce allocations in the ImageElementConverter and ImageIdConverter Read methods These methods show up in the typing scenario in the razor speedometer test as about 0.9% (63 MB) of allocations. 1) Changed ImageIdConverter to be more like ImageElementConverter and not create a JsonDocument object to query 2) Changed several Utf8JsonReader.GetText calls to instead use Utf8JsonReader.CopyString 3) Changed JsonElement.GetString and new Guid(...) to instead use Utf8JsonReader.GetGuid() Note that if this PR is merged, I'll also try to make a change to vslanguageserverclient to also do the same as that code has the same issues. * Fix issue serializing null options in VB * Yield in task continuation to prevent stack overflow * Move to .NET 10 Preview 5 * Remove RemoteControl workaround * Lint response * Lint response * Lint response * Lint response * Lint response * Fix issue with not resetting valueLength (#78890) * Fix issue with not resetting valueLength #78881 was just merged with a small bug, in that valueLength wasn't reset before it was used a second time. If the typeName is > 64 chars, then this would have thrown a different exception than it should have down a couple lines. * remove unused method * Lint response * Lint response * fix compiler side * Simplify workspace hookup in syntactic tagger * Move * Switch to ITextBuffer2 * REvert * REvert * Update src/EditorFeatures/Core/InlineDiagnostics/AbstractDiagnosticsTaggerProvider.cs * Update src/EditorFeatures/Core/StringIndentation/StringIndentationTaggerProvider.cs * Update src/EditorFeatures/Core/Tagging/AsynchronousViewportTaggerProvider.cs * REvert * remove more workspace registration code * Move to .NET 10 Preview 5 (#78906) * Move to .NET 10 Preview 5 * Lint response * Lint response * Lint response * Lint response * Lint response * remove unused method * Lint response * Lint response * fix compiler side * more --------- Co-authored-by: Cyrus Najmabadi <[email protected]> * Fix * Inline Hints - do not allow double click for collection expression type hint (#78900) * do not allow double click for collection expression hint * Update src/EditorFeatures/Test2/InlineHints/CSharpInlineTypeHintsTests.vb Co-authored-by: Cyrus Najmabadi <[email protected]> * comment --------- Co-authored-by: Cyrus Najmabadi <[email protected]> * Add tests * Revert "Update code to use null propagation (#78733)" This reverts commit d785549, reversing changes made to a8808be. * Revert "Move to .NET 10 Preview 5 (#78906)" This reverts commit a7fa681. * fix warning * Revert "Update to using unbound nameof(X<>) expressions (#78731)" This reverts commit 6a09280, reversing changes made to a7fa681. * Revert "Update to using simple untyped lambdas (#78732)" This reverts commit a8808be, reversing changes made to 6a09280. * Fix OOP crash issue with copilot change analysis * Re-enable IDE0051 (#78919) This re-enables the unused member analyzer and removes all of the methods it flagged as unused. * Extensions: address some follow-up comments (#78847) * Pass missing Hot Reload result properties (#78929) * Fix deadlock if an MSBuild task is writing to stdout When we switched over to communicating over a named pipe rather than stdin/stdout, we were still redirecting stdin and stdout. This had the side effect that if a build task was directly writing to standard out, the build would eventually deadlock since we weren't reading from the other side. I thought about simply not redirecting stdin/stdout, but I could imagine other problems might come up if we were to have multiple build hosts trying to share stdin/stdout. So now we'll log stdout the same way we log stderr, and explicitly close stdin so readers won't deadlock waiting for input. Fixes #78766 * Revert * Collect stats * Extensions: allow cref references to extension members (#78735) * Fix scoped variance checks involving ref struct interface implementation (#78883) * Remove now unused Progression references and related hacks * Expose a couple of things to Razor * Remove more unneeded references * Obsolete api * [main] Source code updates from dotnet/dotnet (#78805) * [VMR] Codeflow a528f84-a528f84 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 270315 No dependency updates to commit * [VMR] Codeflow f5faea9-f5faea9 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 270450 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 270603 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 270662 No dependency updates to commit * [VMR] Codeflow 86826d3-86826d3 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271018 No dependency updates to commit * [VMR] Codeflow 32a2620-32a2620 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271181 No dependency updates to commit * [VMR] Codeflow 25357a9-25357a9 [[ commit created by automation ]] * Update dependencies from https://github.com/dotnet/dotnet build 271343 No dependency updates to commit * Update dependencies from https://github.com/dotnet/dotnet build 271417 No dependency updates to commit * Revert incorrect Roslyn.sln changes --------- Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]> * Code simplification * Specify single reducer * Simplify * Add test * Only add annotations to potential references * :Extract type * Docs * move up * Expose `IsIterator` as a public API (#78813) * Expose `IsIterator` as a public API * Fix workspace generated method symbol implementation * Implement new property in yet another non-compiler-owned method symbol implementation * SemanticSearch.ReferenceAssemblies * Verify public code path in C# * Add negative tests * Add C# local function tests * Test VB lambda iterators * Revert accessibility change * Disable warnings * Use explicit type * Simplify lambda tests * Test interface property * Add additional VB case * Update enum values * PR Feedback --------- Co-authored-by: Cyrus Najmabadi <[email protected]> Co-authored-by: Cyrus Najmabadi <[email protected]> Co-authored-by: Todd Grunke <[email protected]> Co-authored-by: David Barbet <[email protected]> Co-authored-by: David Barbet <[email protected]> Co-authored-by: Jason Malinowski <[email protected]> Co-authored-by: John Douglas Leitch <[email protected]> Co-authored-by: DoctorKrolic <[email protected]> Co-authored-by: Rikki Gibson <[email protected]> Co-authored-by: AlekseyTs <[email protected]> Co-authored-by: Ankita Khera <[email protected]> Co-authored-by: Tomáš Matoušek <[email protected]> Co-authored-by: Julien Couvreur <[email protected]> Co-authored-by: Joey Robichaud <[email protected]> Co-authored-by: Jan Jones <[email protected]> Co-authored-by: DoctorKrolic <[email protected]> Co-authored-by: Chris Sienkiewicz <[email protected]> Co-authored-by: Joey Robichaud <[email protected]> Co-authored-by: tmat <[email protected]> Co-authored-by: Jared Parsons <[email protected]> Co-authored-by: David Wengier <[email protected]> Co-authored-by: dotnet-maestro[bot] <42748379+dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: dotnet-maestro[bot] <dotnet-maestro[bot]@users.noreply.github.com> Co-authored-by: Viktor Hofer <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I will need to do a few passes. This is a first round.
Relates to test plan #76130