Move off of a linear walk in solution-explorer symbol tree updates. #78771
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CyrusNajmabadi
commented
May 30, 2025
src/VisualStudio/Core/Impl/SolutionExplorer/SymbolTree/SymbolTreeChildCollection.cs
Outdated
Show resolved
Hide resolved
…reeChildCollection.cs
dibarbet
approved these changes
May 30, 2025
| @@ -10,6 +10,7 @@ | |||
| using System.ComponentModel.Composition; | |||
| using System.Threading; | |||
| using System.Threading.Tasks; | |||
| using ICSharpCode.Decompiler.Util; | |||
There was a problem hiding this comment.
yes. it's where we get multi-dictionary from that supports removing a particular FilePath-Source pair.
CyrusNajmabadi
commented
May 30, 2025
| public async Task UpdateIfAffectedAsync( | ||
| HashSet<string> updatedFilePaths, | ||
| CancellationToken cancellationToken) | ||
| public async Task UpdateIfEverExpandedAsync(CancellationToken cancellationToken) |
There was a problem hiding this comment.
A nice part of this is no need to pass "these were the changed files along". we automatically are updating the source for the files that changed directly.
CyrusNajmabadi
commented
May 30, 2025
| @@ -95,27 +91,10 @@ public async Task UpdateIfAffectedAsync( | |||
| } | |||
| } | |||
|
|
|||
| private string? TryGetCanonicalName() | |||
There was a problem hiding this comment.
made into a local function inside DetermineDocumentId
This was referenced Jun 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Followup to #78754.
Updates our core structure to be a dictionary keyed off of the IVsHierarchyItem's CanonicalName instead.