Skip to content

Selectively persist the commandline to temporary storage #78441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 13, 2025
Merged

Selectively persist the commandline to temporary storage #78441

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
ba46cf4
*** WIP: Selectively persist the commandline to temporary storage
ToddGrun May 5, 2025
0b8d486
Remove the complication of using ITemporaryStorageStreamHandle
ToddGrun May 7, 2025
a4753e3
add back xmldoc closing tag
ToddGrun May 7, 2025
af82a35
1) Set _commandLine to default in case where it shouldn't be used and…
ToddGrun May 9, 2025
4471760
Better handle legacy project system calls to set ExplicitRuleSetFilePath
ToddGrun May 13, 2025
71498b6
add abstract keyword for class intended to be abstract
ToddGrun May 13, 2025
f1f614e
make virtual method return a bool to allow field to remain private
ToddGrun May 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions src/Workspaces/Core/Portable/Workspace/ProjectSystem/ProjectSystemProjectOptionsProcessor.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,11 +70,15 @@ private bool ReparseCommandLineIfChanged_NoLock(ImmutableArray<string> arguments

_commandLineChecksum = checksum;

ReparseCommandLine_NoLock(arguments);

// Dispose the existing stored command-line and then persist the new one so we can
// recover it later. Only bother persisting things if we have a non-empty string.
// recover it later. Only bother persisting things if we have a non-empty string
// and there is an effective ruleset (as that ends up adding RuleSetFile_UpdatedOnDisk
// as an event handler which is the only consumer of _commandLineStorageHandle)

_commandLineStorageHandle = null;
if (!arguments.IsEmpty)
if (!arguments.IsEmpty && GetEffectiveRulesetFilePath() != null)
{
using var stream = SerializableBytes.CreateWritableStream();
using var writer = new StreamWriter(stream);
Expand All @@ -86,7 +90,6 @@ private bool ReparseCommandLineIfChanged_NoLock(ImmutableArray<string> arguments
_commandLineStorageHandle = _temporaryStorageService.WriteToTemporaryStorage(stream, CancellationToken.None);
}

ReparseCommandLine_NoLock(arguments);
return true;
}

Expand Down Expand Up @@ -173,9 +176,12 @@ public CommandLineArguments GetParsedCommandLineArguments()
return _commandLineArgumentsForCommandLine;
}

private string? GetEffectiveRulesetFilePath()
=> ExplicitRuleSetFilePath ?? _commandLineArgumentsForCommandLine.RuleSetPath;

private void UpdateProjectOptions_NoLock()
{
var effectiveRuleSetPath = ExplicitRuleSetFilePath ?? _commandLineArgumentsForCommandLine.RuleSetPath;
var effectiveRuleSetPath = GetEffectiveRulesetFilePath();

if (_ruleSetFile?.Target.Value.FilePath != effectiveRuleSetPath)
{
Expand Down
Loading