Merge branch 'main' into 'extensions' #78374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…408.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.XliffTasks From Version 9.0.0-beta.25204.5 -> To Version 9.0.0-beta.25208.6
…service can be moved
…dotnet#78334) In VS Code, Razor cohosting logs to the Razor Log output category as you would expect, but all of the CLaSP logging ends up in the C# output, including all of the MEF composition and ALC processing stuff, which is relatively noisy. This fixes that by remapping logs to the Razor log endpoint for contexts that specify the Razor language, and makes requests for Razor specify that context. This is a bit of speculative work on a Sunday, so feel free to reject or suggest a different API. I don't really love having a separate method for this, but having one method with two parameters would mean nobody ever passes in both parameters. The results at runtime in VS Code are huge though, and will make investigating issues easier for us and you. Part of dotnet/razor#11759
* Add dump reporting for dotnet#76225 This is very likely somehow related to dotnet#74728 but is proving very difficult to track down without a repro or a dump.
Followup to dotnet#78356. Needed so we can access IDiagAnalyzerService in OOP. Currently one cannot as it attempts to access the Workspace of a document passed into it. We block WOrkspace access like for safety/clarity concerns (we don't want a stateless OOP api call to have access to the mutable workspace API). This also cleans up some ugly initialization code IDiagAnalyzerService had.
was reading logic on semantic search and thought to push a few non-functional nit cleanup
…ction initializer (dotnet#78336)
fixes dotnet#76999 Support TypeSubstitutedLocalSymbol's in MethodToStateMachineRewriter.HoistRefInitialization
…tnet#78333) About 4.1% of main thread CPU costs during solution load are in workspace eventing. This moves nearly all those costs to background threads. The majority of the workspace changed handler costs are associated with ProjectCodeModelFactoy. If there were any questions about the event handler needing the main thread, this PR attempts to be safe, and continue to use the main thread. Future PRs can judiciously look at moving event handlers to work on background threads. Test insertion PR: https://dev.azure.com/devdiv/DevDiv/_git/VS/pullrequest/631924 See PR for before/after images of CPU usage characteristics.
ghost
added
the
untriaged
AlekseyTs
changed the title
jjonescz
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.