Skip to content

Simplify Impl interface tests #78351

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Apr 28, 2025

Conversation

CyrusNajmabadi
Copy link
Member

CodeActionIndex=0 is redundant. It's the default.
Specifying equivalence key isn't desirable, and makes the tests brittle and hard to maintain.

@CyrusNajmabadi CyrusNajmabadi requested a review from a team as a code owner April 28, 2025 17:21
@ghost ghost added Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 28, 2025
@CyrusNajmabadi CyrusNajmabadi merged commit f7bbe5d into dotnet:main Apr 28, 2025
24 of 25 checks passed
@CyrusNajmabadi CyrusNajmabadi deleted the implInterfaceTests branch April 28, 2025 19:48
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area-IDE untriaged Issues and PRs which have not yet been triaged by a lead VSCode
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants