Implement SeparatedSyntaxList.Count(Func<T, bool>) #78348
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CSharpAttributeData.IsTargetEarlyAttribute was calling the Linq version of this list, and thus boxing the SeparatedSyntaxList enumerator, showing up as 6.5 MB (0.1%) of allocations in our OOP process during solution load. Not a huge win, but it's nice to add to the pit of success for using this type. Modifications to AttributeData just started with changing IsTargetEarlyAttribute to demonstrate the Count usage. I then looked to see what other Linq usage was in the file, and it made sense to change those too.
ghost
added
Area-Compilers
untriaged
AlekseyTs
reviewed
Apr 28, 2025
| @@ -116,6 +116,22 @@ public static bool Any<TNode>(this SeparatedSyntaxList<TNode> list, SyntaxKind k | |||
| return list.IndexOf(kind) >= 0; | |||
| } | |||
|
|
|||
| internal static int Count<TNode>(this SeparatedSyntaxList<TNode> list, Func<TNode, bool> predicate) | |||
There was a problem hiding this comment.
No, and I'm very amenable to moving this wherever you think appropriate. I saw the linq-like extension methods right above this one, so that is where I put this, but if you think there's a better place for this, I'll go ahead and move it.
There was a problem hiding this comment.
Since there is nothing C# specific in this helper, I think it should not be added to CSharpExtensions. Please look for a better place so that VB code could also take advantage of the helper.
There was a problem hiding this comment.
Moved to a non-C# specific location, but kept as an extension method.
cston
approved these changes
Apr 28, 2025
cston
approved these changes
Apr 28, 2025
This was referenced Apr 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CSharpAttributeData.IsTargetEarlyAttribute was calling the Linq version of this list, and thus boxing the SeparatedSyntaxList enumerator, showing up as 5.9 MB (0.1%) of allocations in our OOP process during solution load.
Not a huge win, but it's nice to add to the pit of success for using this type.
Modifications to CSharpAttributeData started with a small cleanup to IsTargetEarlyAttribute to demonstrate the Count() usage. I then looked to see what other Linq usage was in the file, and it made sense to change those too.
*** Allocations in question ***
