Skip to content

Provide overloads for IncrementalValue[s]Provider.Combine #78316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+39 −0
Draft

Provide overloads for IncrementalValue[s]Provider.Combine #78316

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ccda1d3
Combine up to 5 providers
StephaneDelcroix Apr 25, 2025
6ac98a0
Combine up to 7+1 providers
StephaneDelcroix May 2, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,20 @@
public static IncrementalValueProvider<ImmutableArray<TSource>> Collect<TSource>(this IncrementalValuesProvider<TSource> source) => new IncrementalValueProvider<ImmutableArray<TSource>>(new BatchNode<TSource>(source.Node), source.CatchAnalyzerExceptions);

public static IncrementalValuesProvider<(TLeft Left, TRight Right)> Combine<TLeft, TRight>(this IncrementalValuesProvider<TLeft> provider1, IncrementalValueProvider<TRight> provider2) => new IncrementalValuesProvider<(TLeft, TRight)>(new CombineNode<TLeft, TRight>(provider1.Node, provider2.Node), provider1.CatchAnalyzerExceptions);

public static IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)> Combine<TProvider1, TProvider2, TProvider3>(this IncrementalValuesProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3) => provider1.Combine(provider2).Combine(provider3).Select(static (t, _) => (t.Left.Left, t.Left.Right, t.Right));

Check failure on line 33 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI (Correctness Correctness_Analyzers)

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L33 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(33,117): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 33 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L33 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(33,117): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

public static IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4)> Combine<TProvider1, TProvider2, TProvider3, TProvider4>(this IncrementalValuesProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3, IncrementalValueProvider<TProvider4> provider4) => provider1.Combine(provider2).Combine(provider3).Combine(provider4).Select(static (t, _) => (t.Left.Left.Left, t.Left.Left.Right, t.Left.Right, t.Right));

Check failure on line 35 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI (Correctness Correctness_Analyzers)

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L35 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(35,136): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3, TProvider4>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider4> provider4) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 35 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L35 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(35,136): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3, TProvider4>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider4> provider4) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

public static IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4, TProvider5 provider5)> Combine<TProvider1, TProvider2, TProvider3, TProvider4, TProvider5>(this IncrementalValuesProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3, IncrementalValueProvider<TProvider4> provider4, IncrementalValueProvider<TProvider5> provider5) => provider1.Combine(provider2).Combine(provider3).Combine(provider4).Combine(provider5).Select(static (t, _) => (t.Left.Left.Left.Left, t.Left.Left.Left.Right, t.Left.Left.Right, t.Left.Right, t.Right));

Check failure on line 37 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI (Correctness Correctness_Analyzers)

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L37 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(37,158): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3, TProvider4, TProvider5>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider4> provider4, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider5> provider5) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4, TProvider5 provider5)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 37 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L37 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(37,158): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3, TProvider4, TProvider5>(this Microsoft.CodeAnalysis.IncrementalValuesProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider4> provider4, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider5> provider5) -> Microsoft.CodeAnalysis.IncrementalValuesProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4, TProvider5 provider5)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

public static IncrementalValueProvider<(TLeft Left, TRight Right)> Combine<TLeft, TRight>(this IncrementalValueProvider<TLeft> provider1, IncrementalValueProvider<TRight> provider2) => new IncrementalValueProvider<(TLeft, TRight)>(new CombineNode<TLeft, TRight>(provider1.Node, provider2.Node), provider1.CatchAnalyzerExceptions);

public static IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)> Combine<TProvider1, TProvider2, TProvider3>(this IncrementalValueProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3) => provider1.Combine(provider2).Combine(provider3).Select(static (t, _) => (t.Left.Left, t.Left.Right, t.Right));

Check failure on line 41 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI (Correctness Correctness_Analyzers)

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L41 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(41,116): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3>(this Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3) -> Microsoft.CodeAnalysis.IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

Check failure on line 41 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L41 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(41,116): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3>(this Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3) -> Microsoft.CodeAnalysis.IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

public static IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4)> Combine<TProvider1, TProvider2, TProvider3, TProvider4>(this IncrementalValueProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3, IncrementalValueProvider<TProvider4> provider4) => provider1.Combine(provider2).Combine(provider3).Combine(provider4).Select(static (t, _) => (t.Left.Left.Left, t.Left.Left.Right, t.Left.Right, t.Right));

Check failure on line 43 in src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs

View check run for this annotation

Azure Pipelines / roslyn-CI (Correctness Correctness_Analyzers)

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs#L43 

src/Compilers/Core/Portable/SourceGeneration/Nodes/ValueSourceExtensions.cs(43,135): error RS0016: (NETCORE_ENGINEERING_TELEMETRY=Build) Symbol 'static Microsoft.CodeAnalysis.IncrementalValueProviderExtensions.Combine<TProvider1, TProvider2, TProvider3, TProvider4>(this Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider1> provider1, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider2> provider2, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider3> provider3, Microsoft.CodeAnalysis.IncrementalValueProvider<TProvider4> provider4) -> Microsoft.CodeAnalysis.IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4)>' is not part of the declared public API (https://github.com/dotnet/roslyn-analyzers/blob/main/src/PublicApiAnalyzers/PublicApiAnalyzers.Help.md)

public static IncrementalValueProvider<(TProvider1 provider1, TProvider2 provider2, TProvider3 provider3, TProvider4 provider4, TProvider5 provider5)> Combine<TProvider1, TProvider2, TProvider3, TProvider4, TProvider5>(this IncrementalValueProvider<TProvider1> provider1, IncrementalValueProvider<TProvider2> provider2, IncrementalValueProvider<TProvider3> provider3, IncrementalValueProvider<TProvider4> provider4, IncrementalValueProvider<TProvider5> provider5) => provider1.Combine(provider2).Combine(provider3).Combine(provider4).Combine(provider5).Select(static (t, _) => (t.Left.Left.Left.Left, t.Left.Left.Left.Right, t.Left.Left.Right, t.Left.Right, t.Right));

// helper for filtering
public static IncrementalValuesProvider<TSource> Where<TSource>(this IncrementalValuesProvider<TSource> source, Func<TSource, bool> predicate) => source.SelectMany((item, _) => predicate(item) ? ImmutableArray.Create(item) : ImmutableArray<TSource>.Empty);
Expand Down
Loading