Allow Razor files to be additional documents in a misc files project #78267
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
Area-IDE
untriaged
jasonmalinowski
approved these changes
Apr 23, 2025
Comment on lines
72
to
73
| var id = projectInfo.Documents.Single().Id; | ||
| return CurrentSolution.GetRequiredDocument(id); |
There was a problem hiding this comment.
I kinda wish this was an else block so it was more visually clear it's the same logic, but don't touch it unless you have to touch the PR for some other reason.
| @@ -27,7 +27,11 @@ internal static ProjectInfo CreateMiscellaneousProjectInfoForDocument( | |||
| var fileExtension = PathUtilities.GetExtension(filePath); | |||
| var fileName = PathUtilities.GetFileName(filePath); | |||
|
|
|||
| var languageServices = services.GetLanguageServices(languageInformation.LanguageName); | |||
| // For Razor files we need to override the language name to C# as thats what code is generated | |||
| var isRazor = languageInformation.LanguageName == "Razor"; | |||
There was a problem hiding this comment.
Do we not have a constant for this?
There was a problem hiding this comment.
Not one accessible in this layer.
This was referenced Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a startup crash in VS Code if a .razor or .cshtml file is restored in the workspace.
Part of dotnet/razor#11759