Merge 'main' into UserDefinedCompoundAssignment #78262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…hanges Additionally, reduce false positives in telemetry reporting inefficiencies in project system interactions wrt Preprocessor directives.
…onsInBatch 2) Simplify obtaining ISyntaxTreeFactoryService 3) Change version reference 4) Quote potential string containing value in targets files
CPS appears to have moved to the new one several years ago, so we can delete this now.
…stemProject.cs Co-authored-by: Cyrus Najmabadi <[email protected]>
…stemProject.cs Co-authored-by: Cyrus Najmabadi <[email protected]>
…ence-packages build 20250410.1 Microsoft.SourceBuild.Intermediate.source-build-reference-packages From Version 10.0.620702 -> To Version 10.0.621001
I'm a bit suspicious that re-enabling that exception might be unsafe, so let's be a bit friendlier.
Stuff we can delete I noticed while looking at a potential performance improvement.
…otnet#78051) This PR restores behavior introduced in dotnet#77768 that were reverted in PR dotnet#77983. The revert occurred as it was flagged for causing ddrit regressions in some of the WinformsVS64.Designer tests. I was unable to reproduce this scenario locally, but the RPS tests are able to reliably hit this issue. Digging into it a bit indicated that creating the OpenTextBufferProvider on a bg thread somehow a thread affinity that caused microsoft.visualstudio.shell.design.ni!DocData.CreateNativeDocData's call to msenv!CEditorManager::RegisterInvisibleEditor's to require an RPC main->bg thread switch. This breaks the assumptions of RegisterInvisibleEditor and weird things start happening. Jason helped track down the likely culprit, and logged https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2441480 to track that work. This PR works around that issue by obtaining the RDT while on the main thread. I've logged dotnet#78050 to track the Roslyn cleanup necessary once obtaining the rdt can be done from a background thread. a) Restores changes from PR dotnet#77768 that were reverted in PR dotnet#77983 b) Ensure OpenTextBufferProvider._runningDocumentTable is initialized on the main thread. c) Added comments about https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2441480 and created a tracking bug for us to clean this up once it's fixed (dotnet#78050)
…ml (dotnet#78206) This is to replace the current consumption in the VS repo that is consuming this project out of VS.ExternalAPIs.Roslyn.
…ataReferenceResolver.cs
…ataReferenceResolver.cs
We can depend on Build rather than be AfterTargets="Build" so that way we don't run when we don't expect to be.
* Clean up output capture on .NET Core This cleans up how we handle output capture on .NET Core. This moves from a lot of mutable `static` static, that would break if tests ran in parallel, to instance state that uses locks to guard againtst concurrent runs. * more * more
no longer in p3
no longer in p3
ghost
added
the
untriaged
jjonescz
approved these changes
Apr 23, 2025
AlekseyTs
merged commit 7fb0864
into
dotnet:features/UserDefinedCompoundAssignment
28 checks passed
This was referenced May 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.