Add more telemetry for progression graph query commands to help better understand usage patterns #78202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r understand usage patterns
ghost
added
Area-IDE
untriaged
arunchndr
approved these changes
Apr 18, 2025
|
@ToddGrun can we please cherry pick to 17.14 when you get a chance? |
|
| @@ -18,6 +19,8 @@ internal sealed partial class SearchGraphQuery( | |||
| { | |||
| public async Task<GraphBuilder> GetGraphAsync(Solution solution, IGraphContext context, CancellationToken cancellationToken) | |||
| { | |||
| using var _ = Logger.LogBlock(FunctionId.GraphQuery_Search, KeyValueLogMessage.Create(LogType.UserAction), cancellationToken); | |||
There was a problem hiding this comment.
Does this LogType.UserAction mean we'll actually get a telemetry event created?
There was a problem hiding this comment.
Cyrus asked something similar in the 17.14 PR. LogType doesn't seem to matter for telemetry, but this defaults the logLevel to LogLevel.Information. The telemetry logger ignores message with LogLevel < LogLevel.Information
This was referenced Apr 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us understand better which commands are being used and the efforts we should expend to continue supporting certain commands if we move from the progression APIs to IAttachedCollectionSourceProvider.