Skip to content

Fix Local-Symbol Containing-Symbol in New-Extension-Method-Rewriter for Capture Analysis #78160

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 15 commits into from
Apr 18, 2025
Merged

Fix Local-Symbol Containing-Symbol in New-Extension-Method-Rewriter for Capture Analysis #78160

merged 15 commits into from
Apr 18, 2025

Conversation

bernd5
Copy link
Contributor

@bernd5 bernd5 commented Apr 15, 2025 •
edited by jcouv
Loading

fixes #78135
fixes #78042

Relates to test plan #76130

@ghost ghost added Area-Compilers untriaged Issues and PRs which have not yet been triaged by a lead labels Apr 15, 2025
@dotnet-policy-service dotnet-policy-service bot added the Community The pull request was submitted by a contributor who is not a Microsoft employee. label Apr 15, 2025
@bernd5 bernd5 marked this pull request as ready for review April 15, 2025 14:17
@bernd5 bernd5 requested a review from a team as a code owner April 15, 2025 14:17
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 15, 2025 •
edited
Loading

@bernd5 Please provide a more descriptive title for the PR, the title that reflects the nature of the changes #Closed

@bernd5 bernd5 changed the title fixes #78135 Fix Local-Symbol Containing-Type in New-Extension-Method-Rewriter for Capture Analysis Apr 15, 2025
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 15, 2025 •
edited
Loading

Fix Local-Symbol Containing-Type in New-Extension-Method-Rewriter for Capture Analysis

"Containing-Type" or "Containing-Symbol"? #Closed

@bernd5 bernd5 changed the title Fix Local-Symbol Containing-Type in New-Extension-Method-Rewriter for Capture Analysis Fix Local-Symbol Containing-Symbol in New-Extension-Method-Rewriter for Capture Analysis Apr 15, 2025
@AlekseyTs
Copy link
Contributor

AlekseyTs commented Apr 15, 2025 •
edited
Loading

Done with review pass (commit 5) #Closed

@AlekseyTs AlekseyTs requested a review from jcouv April 15, 2025 15:00
@AlekseyTs AlekseyTs added the Feature - Extension Everything The extension everything feature label Apr 15, 2025
@bernd5 bernd5 mentioned this pull request Apr 15, 2025
Closed
@bernd5
Copy link
Contributor Author

bernd5 commented Apr 16, 2025

I assume the faild tests have nothing todo with my change - some helix stuff 🤷

@AlekseyTs
Copy link
Contributor

Done with review pass (commit 11)

@AlekseyTs
Copy link
Contributor

@jcouv For the second review

jcouv
jcouv approved these changes Apr 16, 2025
View reviewed changes
Copy link
Member

@jcouv jcouv left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM Thanks (iteration 14)

AlekseyTs
AlekseyTs approved these changes Apr 16, 2025
View reviewed changes
Copy link
Contributor

@AlekseyTs AlekseyTs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (commit 15)

@AlekseyTs AlekseyTs enabled auto-merge (squash) April 16, 2025 20:03
@AlekseyTs
Copy link
Contributor

@bernd5 Thanks for the contribution!

@bernd5
Copy link
Contributor Author

bernd5 commented Apr 17, 2025

@AlekseyTs @jcouv
When is it merged?

@jjonescz
Copy link
Member

Main branch is currently locked due to some infra issues.

@jaredpar jaredpar disabled auto-merge April 18, 2025 15:04
@jaredpar jaredpar merged commit d329245 into dotnet:main Apr 18, 2025
24 checks passed
@dotnet-policy-service dotnet-policy-service bot added this to the Next milestone Apr 18, 2025
This was referenced Apr 19, 2025
Closed
Closed
This was referenced Apr 29, 2025
Closed
Closed
@bernd5 bernd5 mentioned this pull request May 30, 2025
Closed
@dotnet-bot dotnet-bot mentioned this pull request May 31, 2025
Closed
@bernd5 bernd5 mentioned this pull request Jun 11, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlekseyTs AlekseyTs AlekseyTs approved these changes

@jcouv jcouv jcouv approved these changes

Assignees
No one assigned
Labels
Area-Compilers Community The pull request was submitted by a contributor who is not a Microsoft employee. Feature - Extension Everything The extension everything feature untriaged Issues and PRs which have not yet been triaged by a lead
Projects
None yet
Milestone
Next
Development

Successfully merging this pull request may close these issues.

C# 14 Preview 3 massive errors for nested functional extensions Crash compiling extension static method
5 participants
@bernd5 @AlekseyTs @jjonescz @jcouv @jaredpar